Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-1060 Add usdev to additional regions config #11612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

watsondm
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-1060

📔 Objective

This populates the web vault client additionalRegions configuration with USDEV environment details to fix an issue where the web vault defaults to self hosted region if one isn't explicitly defined. This issue was leading to an incorrect url being generated when enabling SCIM provisioning on an Organization in the USDEV environment.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@watsondm watsondm requested a review from a team October 17, 2024 20:40
Copy link
Member

@sneakernuts sneakernuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @watsondm

Might need another pair of eyes from @bitwarden/team-vault-dev and @bitwarden/team-platform-dev based on previous PRs.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.20%. Comparing base (133257f) to head (e9d804d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11612   +/-   ##
=======================================
  Coverage   33.20%   33.20%           
=======================================
  Files        2782     2782           
  Lines       86484    86484           
  Branches    16484    16484           
=======================================
  Hits        28714    28714           
  Misses      55483    55483           
  Partials     2287     2287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Logo
Checkmarx One – Scan Summary & Details62670529-7a60-4ead-861e-f28a9f920666

Fixed Issues

Severity Issue Source File / Package
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /libs/common/src/platform/services/sdk/default-sdk.service.ts: 155
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /libs/common/src/platform/services/sdk/default-sdk.service.ts: 172

@watsondm watsondm requested review from a team, coroiu and cd-bitwarden October 17, 2024 21:07
@watsondm
Copy link
Contributor Author

Looks good @watsondm

Might need another pair of eyes from @bitwarden/team-vault-dev and @bitwarden/team-platform-dev based on previous PRs.

Added more to the reviewers on the PR just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants