Accept half-days for ChronoUnit Argument
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Agree this is the pragmatic choice. |
|
@bkirwi Would it be possible to make a release sometime soon? |
|
apologies, was away on holiday over the last couple weeks... i'll get one out in the next ~day. |
|
just released as 2.2.0, though it may still be percolating... let me know if you run into any issues! |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick solution for #335 which just replaces
_with-so thathalf-daysis an acceptable command line argument (as well ashalf_days)There is an argument that we should do a nicer solution like what is done in pureconf, i.e. support for converting from one case to another (and vice versa) but this is a bigger task.