Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to NX 17 #83

Merged
merged 7 commits into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc-overrides.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
"files": ["*.ts"],
"rules": {
"@typescript-eslint/ban-types": "warn",
"@typescript-eslint/explicit-function-return-type": "warn",
"@typescript-eslint/no-empty-function": "warn",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/no-non-null-assertion": "warn",
"@typescript-eslint/explicit-function-return-type": "warn"
"@typescript-eslint/no-unused-vars": "warn"
}
}
]
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ jobs:
key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
- name: Code coverage
run: |
npx nx affected --target=test --browsers=ChromeHeadless --code-coverage --parallel=${{ env.MATRIX_SIZE }} --progress=false --source-map --watch=false
npx nx affected --target=posttest --browsers=ChromeHeadless --parallel=${{ env.MATRIX_SIZE }} --watch=false
npx nx affected --target=test,posttest --configuration=ci --parallel=${{ env.MATRIX_SIZE }}

stop-agents:
name: Stop Nx Cloud agents
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,5 @@ testem.log
Thumbs.db

.angular

.nx/cache
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ CHANGELOG.md

# Prismjs language imports need to be in a specific, non-alphabetical order.
libs/code-block/src/lib/modules/code-block/prism-languages.ts

/.nx/cache
8 changes: 1 addition & 7 deletions apps/playground/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,7 @@
}
},
"lint": {
"executor": "@nx/linter:eslint",
"options": {
"lintFilePatterns": [
"apps/playground/**/*.ts",
"apps/playground/**/*.html"
]
}
"executor": "@nx/eslint:lint"
}
},
"tags": []
Expand Down
20 changes: 11 additions & 9 deletions libs/clipboard/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"executor": "@nx/angular:package",
"outputs": ["{workspaceRoot}/dist/{projectRoot}"],
"options": {
"project": "libs/clipboard/ng-package.json",
"updateBuildableProjectDepsInPackageJson": false
"project": "libs/clipboard/ng-package.json"
},
"configurations": {
"production": {
Expand All @@ -34,16 +33,19 @@
"node_modules/@skyux/theme/css/sky.css",
"node_modules/@skyux/theme/css/themes/modern/styles.css"
]
},
"configurations": {
"ci": {
"browsers": "ChromeHeadless",
"codeCoverage": true,
"progress": false,
"sourceMap": true,
"watch": false
}
}
},
"lint": {
"executor": "@nx/linter:eslint",
"options": {
"lintFilePatterns": [
"libs/clipboard/**/*.ts",
"libs/clipboard/**/*.html"
]
}
"executor": "@nx/eslint:lint"
}
},
"tags": ["component", "npm"]
Expand Down
20 changes: 11 additions & 9 deletions libs/code-block/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"executor": "@nx/angular:package",
"outputs": ["{workspaceRoot}/dist/{projectRoot}"],
"options": {
"project": "libs/code-block/ng-package.json",
"updateBuildableProjectDepsInPackageJson": false
"project": "libs/code-block/ng-package.json"
},
"configurations": {
"production": {
Expand All @@ -34,16 +33,19 @@
"node_modules/@skyux/theme/css/sky.css",
"node_modules/@skyux/theme/css/themes/modern/styles.css"
]
},
"configurations": {
"ci": {
"browsers": "ChromeHeadless",
"codeCoverage": true,
"progress": false,
"sourceMap": true,
"watch": false
}
}
},
"lint": {
"executor": "@nx/linter:eslint",
"options": {
"lintFilePatterns": [
"libs/code-block/**/*.ts",
"libs/code-block/**/*.html"
]
}
"executor": "@nx/eslint:lint"
}
},
"tags": ["component", "npm"]
Expand Down
17 changes: 11 additions & 6 deletions libs/media/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"executor": "@nx/angular:package",
"outputs": ["{workspaceRoot}/dist/{projectRoot}"],
"options": {
"project": "libs/media/ng-package.json",
"updateBuildableProjectDepsInPackageJson": false
"project": "libs/media/ng-package.json"
},
"configurations": {
"production": {
Expand All @@ -34,13 +33,19 @@
"node_modules/@skyux/theme/css/sky.css",
"node_modules/@skyux/theme/css/themes/modern/styles.css"
]
},
"configurations": {
"ci": {
"browsers": "ChromeHeadless",
"codeCoverage": true,
"progress": false,
"sourceMap": true,
"watch": false
}
}
},
"lint": {
"executor": "@nx/linter:eslint",
"options": {
"lintFilePatterns": ["libs/media/**/*.ts", "libs/media/**/*.html"]
}
"executor": "@nx/eslint:lint"
}
},
"tags": ["component", "npm"]
Expand Down
17 changes: 11 additions & 6 deletions libs/stache/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"executor": "@nx/angular:package",
"outputs": ["{workspaceRoot}/dist/{projectRoot}"],
"options": {
"project": "libs/stache/ng-package.json",
"updateBuildableProjectDepsInPackageJson": false
"project": "libs/stache/ng-package.json"
},
"configurations": {
"production": {
Expand Down Expand Up @@ -40,6 +39,15 @@
"node_modules/@skyux/theme/css/sky.css",
"node_modules/@skyux/theme/css/themes/modern/styles.css"
]
},
"configurations": {
"ci": {
"browsers": "ChromeHeadless",
"codeCoverage": true,
"progress": false,
"sourceMap": true,
"watch": false
}
}
},
"posttest": {
Expand All @@ -49,10 +57,7 @@
}
},
"lint": {
"executor": "@nx/linter:eslint",
"options": {
"lintFilePatterns": ["libs/stache/**/*.ts", "libs/stache/**/*.html"]
}
"executor": "@nx/eslint:lint"
}
},
"tags": ["component", "npm"]
Expand Down
1 change: 0 additions & 1 deletion nx.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"npmScope": "stache",
"affected": {
"defaultBase": "main"
},
Expand Down
Loading