[pull] master from chenxiaolong:master #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Update Turkish translations
Fixed line 39
Update Russian translations
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
minSdkVersion is 28.
The feature was removed in version 1.11 because Android has no way of reporting the native sample rate without actually starting a recording. Andd to start a recording with a good buffer size, the sample rate is required, leading to a catch-22. Issue: #110 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
README.md: Remove mention of native sample rate
Bump dependencies and Gradle Wrapper, update Polish translation
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
…ails Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Fix crash when receiving call from a private number
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
FIX: Russian days one, other -> one, few, many
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Bump Gradle Wrapper to 7.5.1
On older Samsung firmware, the telephony framework fails to notify InCallService implementations about call disconnections. This doesn't just happen with BCR. It affects Samsung's own apps too, like Knox's InCallServiceImpl. Due to this bug, none of the following callbacks are called when a call ends: * Call.Callback.onStateChanged with Call.STATE_DISCONNECTING or Call.STATE_DISCONNECTED * Call.Callback.onCallDestroyed * InCallService.onCallRemoved However, it does happen to call Call.Callback.onDetailsChanged when the call state transitions to Call.STATE_DISCONNECTED (which doesn't happen with AOSP). This commit reworks RecorderInCallService to keep track of calls better in the face of these firmware bugs. A call's lifetime begins when InCallService.onCallAdded is called and ends when either InCallService.onCallRemoved is called or the state is Call.STATE_DISCONNECTING or Call.STATE_DISCONNECTED in any other callback. This should work on both well-behaved firmware, like AOSP, and buggy firmware, like Samsung's OneUI. Issue: #143 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
RecorderInCallService: Improve end-of-call detection
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
On Samsung devices, when a call ends, AudioRecord.read() blocks until another call becomes active, which prevents recordings from stopping at the correct time. This behavior does not happen in AOSP. To work around this, use non-blocking reads with a sleep interval of the AudioRecord minimum buffer size. This gives the recording loop a chance to check if recording has been cancelled. Issue: #143 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
RecorderThread: Use non-blocking reads from AudioRecord
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
build: update all dependencies, add buildToolsVersion
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
build.gradle.kts: Avoid breaking gradle's laziness where possible
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
This commit adds a new notification that fires when a call recording completes successfully. It's associated with a new notification channel so it can be disabled without affecting other notifications. The notification has two action buttons: open and share. Both of these do as their name implies and do not dismiss the notification. Clicking on the notification text behaves like open, except the notification is dismissed. The open and share options require a custom ContentProvider because it's not possible to grant the target app permissions to a SAF URI. BCR's RecorderProvider is very minimal and just wraps SAF's provider for the openFile, getType, and query operations. Also, manual action from the user is required for the new open and share options to work. Previously, BCR only requested persistent write permissions to the output directory. This makes it impossible for RecorderProvider to access the recording that was just created. This commit updates the output directory permission logic to also request persistent read permissions, but the user will have to reset the output directory to the default and then select the desired directory again. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Send notification when a call recording completes
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
README.md: Add note about erofs volumes being read-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )