Optimize _.invoke for arrays.

blazzy · Feb 3, 2014 · a1b2058 · a1b2058
1 parent 79b88f4
commit a1b2058
Show file tree

Hide file tree

Showing 9 changed files with 232 additions and 193 deletions.
diff --git a/dist/lodash.compat.js b/dist/lodash.compat.js
@@ -3859,15 +3859,22 @@
      * // => [['1', '2', '3'], ['4', '5', '6']]
      */
     function invoke(collection, methodName) {
-      var args = slice(arguments, 2),
-          index = -1,
+      var index = -1,
           isFunc = typeof methodName == 'function',
           length = collection ? collection.length : 0,
           result = Array(typeof length == 'number' ? length : 0);
 
-      baseEach(collection, function(value) {
-        result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
-      });
+      if (arguments.length < 3 && isArray(collection)) {
+        while (++index < length) {
+          var value = collection[index];
+          result[index] = isFunc ? methodName.call(value) : value[methodName]();
+        }
+      } else {
+        var args = slice(arguments, 2);
+        baseEach(collection, function(value) {
+          result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
+        });
+      }
       return result;
     }
 

diff --git a/dist/lodash.compat.min.js b/dist/lodash.compat.min.js
diff --git a/dist/lodash.js b/dist/lodash.js
@@ -3596,15 +3596,22 @@
      * // => [['1', '2', '3'], ['4', '5', '6']]
      */
     function invoke(collection, methodName) {
-      var args = slice(arguments, 2),
-          index = -1,
+      var index = -1,
           isFunc = typeof methodName == 'function',
           length = collection ? collection.length : 0,
           result = Array(typeof length == 'number' ? length : 0);
 
-      baseEach(collection, function(value) {
-        result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
-      });
+      if (arguments.length < 3 && typeof length == 'number') {
+        while (++index < length) {
+          var value = collection[index];
+          result[index] = isFunc ? methodName.call(value) : value[methodName]();
+        }
+      } else {
+        var args = slice(arguments, 2);
+        baseEach(collection, function(value) {
+          result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
+        });
+      }
       return result;
     }
 

diff --git a/dist/lodash.min.js b/dist/lodash.min.js
diff --git a/dist/lodash.underscore.js b/dist/lodash.underscore.js
@@ -2481,15 +2481,22 @@
    * // => [['1', '2', '3'], ['4', '5', '6']]
    */
   function invoke(collection, methodName) {
-    var args = slice(arguments, 2),
-        index = -1,
+    var index = -1,
         isFunc = typeof methodName == 'function',
         length = collection ? collection.length : 0,
         result = Array(typeof length == 'number' ? length : 0);
 
-    baseEach(collection, function(value) {
-      result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
-    });
+    if (arguments.length < 3 && typeof length == 'number') {
+      while (++index < length) {
+        var value = collection[index];
+        result[index] = isFunc ? methodName.call(value) : value[methodName]();
+      }
+    } else {
+      var args = slice(arguments, 2);
+      baseEach(collection, function(value) {
+        result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
+      });
+    }
     return result;
   }
 

diff --git a/dist/lodash.underscore.min.js b/dist/lodash.underscore.min.js
diff --git a/doc/README.md b/doc/README.md
diff --git a/lodash.js b/lodash.js
@@ -3875,15 +3875,22 @@
      * // => [['1', '2', '3'], ['4', '5', '6']]
      */
     function invoke(collection, methodName) {
-      var args = slice(arguments, 2),
-          index = -1,
+      var index = -1,
           isFunc = typeof methodName == 'function',
           length = collection ? collection.length : 0,
           result = Array(typeof length == 'number' ? length : 0);
 
-      baseEach(collection, function(value) {
-        result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
-      });
+      if (arguments.length < 3 && isArray(collection)) {
+        while (++index < length) {
+          var value = collection[index];
+          result[index] = isFunc ? methodName.call(value) : value[methodName]();
+        }
+      } else {
+        var args = slice(arguments, 2);
+        baseEach(collection, function(value) {
+          result[++index] = (isFunc ? methodName : value[methodName]).apply(value, args);
+        });
+      }
       return result;
     }
 

diff --git a/perf/perf.js b/perf/perf.js
@@ -1228,30 +1228,40 @@
   suites.push(
     Benchmark.Suite('`_.invoke` iterating an array')
       .add(buildName, '\
-        lodash.invoke(numbers, "toFixed", "2")'
+        lodash.invoke(numbers, "toFixed")'
       )
       .add(otherName, '\
-        _.invoke(numbers, "toFixed", "2")'
+        _.invoke(numbers, "toFixed")'
+      )
+  );
+
+  suites.push(
+    Benchmark.Suite('`_.invoke` with arguments iterating an array')
+      .add(buildName, '\
+        lodash.invoke(numbers, "toFixed", 1)'
+      )
+      .add(otherName, '\
+        _.invoke(numbers, "toFixed", 1)'
       )
   );
 
   suites.push(
     Benchmark.Suite('`_.invoke` with a function for `methodName` iterating an array')
       .add(buildName, '\
-        lodash.invoke(numbers, String.prototype.split, "")'
+        lodash.invoke(numbers, Number.prototype.toFixed, 1)'
       )
       .add(otherName, '\
-        _.invoke(numbers, String.prototype.split, "")'
+        _.invoke(numbers, Number.prototype.toFixed, 1)'
       )
   );
 
   suites.push(
     Benchmark.Suite('`_.invoke` iterating an object')
       .add(buildName, '\
-        lodash.invoke(object, "toFixed", "2")'
+        lodash.invoke(object, "toFixed", 1)'
       )
       .add(otherName, '\
-        _.invoke(object, "toFixed", "2")'
+        _.invoke(object, "toFixed", 1)'
       )
   );