Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we access dev instance of comdb2db when on dev #1526

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

dorinhogea
Copy link
Contributor

After refactoring class names, dev clusters try to access prod comdb2db and fail. This patch fixes it.

Copy link
Contributor

@mponomar mponomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, good to merge.

@dorinhogea
Copy link
Contributor Author

thank you

@dorinhogea dorinhogea merged commit b68efb4 into bloomberg:master Apr 24, 2019
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/261 tests failed ⚠.

The first 10 failing tests are:
updcolsbug
odh_blobs

Detail | Log | Resubmit

@dorinhogea dorinhogea deleted the fix_dev_remsql branch April 25, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants