Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On cleanup call thd_cleanup function for pool_t objects #2836

Merged
merged 1 commit into from
May 18, 2021
Merged

On cleanup call thd_cleanup function for pool_t objects #2836

merged 1 commit into from
May 18, 2021

Conversation

adizaimi
Copy link

@adizaimi adizaimi commented May 8, 2021 •
edited
Loading

  • cleanup pool_t objects via thd_cleanup: while not a leak, this frees more than 660KB on exit and makes it easier to identify next items to cleanup
  • break down gbl_thd_linger cond_wait to one second chunks
    and break/exit as early as possible
  • tests setup: append test lrl last to take precedence
  • pthread_attr_setstacksize will fail if size < PTHREAD_STACK_MIN
  • set gbl_db_is_exiting to timestamp of exiting

Signed-off-by: Adi Zaimi azaimi@bloomberg.net

roborivers
roborivers suggested changes May 8, 2021
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 1/405 tests failed ⚠.

The first 10 failing tests are:
ruleset

Detail | Log | Resubmit

roborivers
roborivers suggested changes May 12, 2021
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/405 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
auth
logfill

Detail | Log | Resubmit

roborivers
roborivers suggested changes May 12, 2021
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/405 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
logfill

Detail | Log | Resubmit

roborivers
roborivers suggested changes May 12, 2021
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

Detail | Log | Resubmit

roborivers
roborivers suggested changes May 12, 2021
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/405 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_timepart

Detail | Log | Resubmit

dorinhogea
dorinhogea requested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise changes look good

db/handle_buf.c Show resolved Hide resolved
@adizaimi
On cleanup call thd_cleanup function for pool_t objects (bloomberg#2836)
14a5125 
* cleanup pool_t objects via thd_cleanup: while not a leak, this frees more than
  660KB on exit and makes it easier to identify next items to cleanup
* break down gbl_thd_linger cond_wait to one second chunks
  and break/exit as early as possible
* tests setup: append test lrl last to take precedence
* pthread_attr_setstacksize will fail if size < PTHREAD_STACK_MIN
* set gbl_db_is_exiting to timestamp of exiting

Signed-off-by: Adi Zaimi <azaimi@bloomberg.net>
dorinhogea
dorinhogea approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

roborivers
roborivers suggested changes May 18, 2021
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 1/406 tests failed ⚠.

The first 10 failing tests are:
deadlock_load_noreorder_generated

Detail | Log | Resubmit

@adizaimi adizaimi merged commit a734ba5 into bloomberg:master May 18, 2021
@adizaimi adizaimi deleted the az_thd_cleanup branch May 18, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers requested changes

@dorinhogea dorinhogea dorinhogea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adizaimi @dorinhogea @roborivers