Fix live updates to footers on Textual TUIs #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These actions live on the app, not on the screen. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Avoid proliferation of hacky code. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
This is necessary pre-factoring for fixing the approach we use for changing the descriptions of key bindings in the footer to work on the latest versions of Textual. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
fix_textual_footer
branch
2 times, most recently
from
adab098
to
599fb5a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
+ Coverage 92.55% 92.86% +0.30%
==========================================
Files 91 92 +1
Lines 11304 11234 -70
Branches 1581 2055 +474
==========================================
- Hits 10462 10432 -30
+ Misses 837 802 -35
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
godlygeek
force-pushed
the
fix_textual_footer
branch
2 times, most recently
from
e6cc8a2
to
2fe80b1
Compare
sarahmonod
approved these changes
May 20, 2024
godlygeek
force-pushed
the
fix_textual_footer
branch
from
2fe80b1
to
fd479b0
Compare
In Textual 0.61, `App.namespace_bindings` was removed in favor of `Screen.active_bindings`. Update our implementation to work for both, since we still support Textual versions below 0.61. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
fix_textual_footer
branch
from
fd479b0
to
47e859c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Textual 0.61,
App.namespace_bindingswas removed in favor ofScreen.active_bindings. Update our implementation of dynamically updating footer descriptions to work for both, since we still support Textual versions below 0.61.