Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix a type in native_mode.rst #638

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

gustiando
Copy link
Contributor

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @gustiando!

@godlygeek godlygeek enabled auto-merge (rebase) June 27, 2024 22:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (41248ed) to head (6a2ad30).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   92.55%   93.00%   +0.45%     
==========================================
  Files          91       94       +3     
  Lines       11304    11412     +108     
  Branches     1581     2089     +508     
==========================================
+ Hits        10462    10614     +152     
+ Misses        837      798      -39     
+ Partials        5        0       -5     
Flag Coverage Δ
cpp 93.00% <ø> (+7.06%) ⬆️
python_and_cython 93.00% <ø> (-2.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godlygeek godlygeek merged commit a49daa1 into bloomberg:main Jun 27, 2024
16 of 17 checks passed
@godlygeek godlygeek changed the title Update native_mode.rst docs: Fix a type in native_mode.rst Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants