worker enhancement: NewTxsEvent and triePrefetch reuse #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilliant-lx
requested review from
j75689,
unclezoro,
kyrie-yl,
qinglin89 and
yutianwu
brilliant-lx
changed the title
brilliant-lx
changed the title
avoid too much trie prefetch routines when several fillTransactions are called.
1.remove the unnecessary NewTxsEvent subscriber, which was used for PoW resubmit check. 2.unsubscribe ASAP before another fillTransactions, to avoid block others.
unclezoro
approved these changes
Nov 28, 2022
qinglin89
reviewed
Nov 28, 2022
qinglin89
approved these changes
Nov 28, 2022
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These two PRs is to enhance worker, after multi-fillTransactions(#1186) was introduced.
The node could have stress to handle huge transaction traffic.
This PR tries to reduce some CPU cost and improve the logic of NewTxsEvent Subscribe.
Rationale
Reused triePrefetch
1.reused triePrefetch when multi-fillTransactions to mine a block, to avoid too much trie prefetch routines when several fillTransactions are called.
Subscribe NewTxsEvent
1.remove the unnecessary NewTxsEvent subscriber, which was used for PoW resubmit check.
2.unsubscribe ASAP before another fillTransactions, to avoid block others.
3.double txChanSize to 4096 * 2, so it will less likely to block others when it is running fillTransactions(), which may take 1.5s at most.
Example
NA
Changes
NA