-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove naturally finality #1651
Merged
NathanBSC
merged 1 commit into
bnb-chain:develop
from
node-real:remove_naturally_finality
May 30, 2023
Merged
fix: remove naturally finality #1651
NathanBSC
merged 1 commit into
bnb-chain:develop
from
node-real:remove_naturally_finality
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
remove_naturally_finality
branch
from
May 25, 2023 06:45
dc987dc
to
7ec23fa
Compare
NathanBSC
commented
May 25, 2023
NathanBSC
force-pushed
the
remove_naturally_finality
branch
from
May 25, 2023 07:52
7ec23fa
to
02a9dd6
Compare
What exactly is the reason for removal of |
reason updated |
brilliant-lx
approved these changes
May 26, 2023
unclezoro
approved these changes
May 30, 2023
setunapo
added a commit
to setunapo/bsc-erigon
that referenced
this pull request
May 31, 2023
detail refer: bnb-chain/bsc#1651
setunapo
added a commit
to node-real/bsc-erigon
that referenced
this pull request
May 31, 2023
detail refer: bnb-chain/bsc#1651
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove naturally finality
Rationale
naturally finality is alias of probabilistic finality in the code.
Example
add an example CLI or API response...
Changes
Notable changes: