cmd/utils: allow HTTPHost and WSHost flags precede

[weiihann]

Description

Fixes #2052.

When users specify the http.addr and ws.addr command line flags, they will overwrite the HTTPHost and WSHost in the config file.

Rationale

As a user, I would assume that specifying flags would overwrite the config files. While this is true for most flags, the behavior is the opposite for http.addr and ws.addr.

Example

config.toml

[Node]
HTTPHost = "127.0.0.1"
WSHost = "127.0.0.1"

Command:

./geth --datadir node --mainnet --http --http.addr 0.0.0.0 --ws --ws.addr 0.0.0.0

Expected output:

...
INFO [12-12|14:17:21.325] HTTP server started                      endpoint=[::]:8545 auth=false prefix= cors= vhosts=localhost
INFO [12-12|14:17:21.326] WebSocket enabled                        url=ws://[::]:8546
...

Actual output:

...
INFO [12-12|14:16:47.073] HTTP server started                      endpoint=127.0.0.1:8545 auth=false prefix= cors= vhosts=localhost
INFO [12-12|14:16:47.073] WebSocket enabled                        url=ws://127.0.0.1:8546
...

Changes

Flags will now overwrite the config file instead.

[kaladinlight]

Thanks for the quick update. This change allows the user to override --http.addr and --ws.addr which accurately reflects upstream geth as seen here:

• --http.addr
• --ws.addr