Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: support to disable log rotate by hours #2063

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Dec 13, 2023

Description

log: support to disable log rotate by hours

Rationale

#114 suggest that

So would be nice to add an option into the config file to:

1. rotate by size
2. rotate by date (daily, hourly, weekly, monthly, etc)
3. disable rotation altogether

to support type 1, only rotate by size,
we should have the ablitiy to disable the default one hour rotation, this PR add this support

by setting RotateHours=0 in config.toml, rotate by hours is disabled

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@zzzckck zzzckck merged commit 64be7df into bnb-chain:develop Dec 14, 2023
5 checks passed
@buddh0 buddh0 deleted the can_disable_log_rorate_by_hours branch December 22, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants