p2p: no peer reconnect if explicitly disconnected #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on enode
weiihann
force-pushed
the
develop/explicit-disc
branch
from
628d436
to
085a15c
Compare
MatusKysel
reviewed
Jan 8, 2024
MatusKysel
approved these changes
Jan 8, 2024
weiihann
added a commit
to weiihann/bsc
that referenced
this pull request
Jan 10, 2024
sysvm
pushed a commit
to sysvm/bsc
that referenced
this pull request
Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a feature to stop reconnecting to peers that were explicitly disconnected (i.e. using
admin_removePeer).Rationale
In some cases when we run a cluster of nodes, we would want to avoid those nodes connecting to the same peers. Hence, we would do
admin_removePeer) to disconnect the connections. However, the reality is that peers get reconnected almost immediately after executingadmin_removePeer, as shown in the graph below:Hence, this feature will put a restriction on the explicitly removed peers such that their connections are not accepted unless the node is restarted.
Changes
Notable changes:
disconnectEnodeSetin theServerstructServer.addPeerChecks