Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils, core: only full sync for fast nodes #2280

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

weiihann
Copy link
Contributor

Description

This PR enforces a rule such that when tries-verify-mode is not local, it will always default to full sync instead of snap sync.

Rationale

Snap sync is not supported on fast nodes.

Example

INFO [03-13|13:52:26.157] Starting Geth on BSC mainnet...
INFO [03-13|13:52:26.157] Bumping default cache on mainnet         provided=1024 updated=4096
INFO [03-13|13:52:26.159] Maximum peer count                       ETH=50 total=50
WARN [03-13|13:52:26.163] Only local TriesVerifyMode can support snap sync, resetting to full sync mode=none
...

Changes

  • Fixed minor typo

@zzzckck zzzckck merged commit fd284c7 into bnb-chain:develop Mar 21, 2024
7 checks passed
@Pjrich1313 Pjrich1313 mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants