Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]fix double close channel of subfetcher #366

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Aug 12, 2021

Description

Fix issue #365

Rationale

The current implementation may abort the subfetcher concurrently, it is not threadsafe.

Example

No

Changes

We setup a new routine to process the abort of subfetcher.

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@unclezoro unclezoro merged commit 504424d into master Aug 13, 2021
@unclezoro unclezoro deleted the fix_double_close branch August 13, 2021 03:18
@andrewdotcallahan
Copy link

@guagualvcha Does trie_prefetcher.copy need to be updated as well? Otherwise, on line 131 we could try to close a nil channel for that prefetcher instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants