Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]fix race condition on preimage #797

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

unclezoro
Copy link
Collaborator

Description

We introduce the race condition on preimage when we implement the pipe commit feature.
refer to #757

Rationale

Fix the race condition on preimage:
image

It can be fixed read lock the db when we flush preimage into storaage.

Example

No API changes

Changes

NO

Copy link
Contributor

@setunapo setunapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclezoro unclezoro merged commit 2853198 into bnb-chain:develop Mar 28, 2022
unclezoro added a commit that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants