Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]disable diffsync when pipecommit is enabled #820

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Mar 30, 2022

Description

This PR is going to disable diffsync when pipecommit is enabled.

Rationale

After several rounds of performance improvement, it turns out the diffsync performance is no better than a pipecommit enabled node. This PR is going to disable diffsync when pipecommit is enabled and leave the further enhancement to #819

Example

No

Changes

No

@unclezoro unclezoro merged commit 4598334 into bnb-chain:develop Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants