asynchronous update snap in updatetrie #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flywukong
force-pushed
the
improve-updateSnap
branch
from
dfd67aa
to
3563a29
Compare
yutianwu
previously approved these changes
May 27, 2022
qinglin89
reviewed
May 31, 2022
core/state/state_object.go
Outdated
| for key, value := range dirtyStorage { | ||
| // If state snapshotting is active, cache the data til commit | ||
| if s.db.snap != nil { | ||
| s.db.snapMux.Lock() |
There was a problem hiding this comment.
as mentioned above, could be better to hold Lock out of the for loop
There was a problem hiding this comment.
whole for loop including storage update
setunapo
reviewed
Jun 2, 2022
setunapo
suggested changes
Jun 2, 2022
flywukong
force-pushed
the
improve-updateSnap
branch
from
0d00ec3
to
27f1bfe
Compare
setunapo
reviewed
Jun 2, 2022
setunapo
previously approved these changes
Jun 2, 2022
flywukong
dismissed stale reviews from setunapo, qinglin89, and yutianwu
The base branch was changed.
setunapo
previously approved these changes
Jun 7, 2022
qinglin89
previously approved these changes
Jun 7, 2022
flywukong
force-pushed
the
improve-updateSnap
branch
from
237feb7
to
15e4f1f
Compare
flywukong
force-pushed
the
improve-updateSnap
branch
from
15e4f1f
to
fea1c96
Compare
yutianwu
approved these changes
Jun 7, 2022
forcodedancing
approved these changes
Jun 7, 2022
qinglin89
approved these changes
Jun 7, 2022
brilliant-lx
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the updateTrie function need to update trie node and snap in a for loop, since the snap updating need wait lock , it may make update trie slower , this PR use a groutine to update snap to make update trie more efficient
Rationale
When chasing blocks in batches, the time overhead of volidation is reduced by 10%,
The overall efficiency of batch sync blocks has been improved， the follow lines represents the delay of volidation with pipeline commit
When executing the latest block, the latency of updateTrie is reduced by 30%-40%, the follow lines represents the delay of an updateTrie function call.
Example
add an example CLI or API response...
Changes
Notable changes: