-
Notifications
You must be signed in to change notification settings - Fork 162
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use Eslint instead of Tslint (#1005)
* removed tslint * forgot to commit files * made .eslintrc.js consistent for all subdirs and other cleanup * [removed] includes and files keys from tsconfig.json * removed file level linting exceptions and added details to line level * added changeset * fixed newly introduced linting errors from rebase * enable json import for batch submitter * removed ecdsa-coder * maybe a tsconfig issue? * Update deploy.ts Co-authored-by: smartcontracts <kelvinfichter@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com>
- Loading branch information
3 people
committed
Jun 15, 2021
1 parent
1424370
commit c87e4c7
Showing
66 changed files
with
1,472 additions
and
278 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@eth-optimism/contracts': patch | ||
| --- | ||
|
|
||
| Migrated from tslint to eslint. The preference for lint exceptions is as follows: line level, block level, file level, package level. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| module.exports = { | ||
| "env": { | ||
| "browser": true, | ||
| "es6": true | ||
| }, | ||
| "extends": [ | ||
| "prettier", | ||
| ], | ||
| "ignorePatterns": ["dist/**/*.ts"], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "project": "tsconfig.json", | ||
| "sourceType": "module" | ||
| }, | ||
| "plugins": [ | ||
| "eslint-plugin-import", | ||
| "eslint-plugin-unicorn", | ||
| "eslint-plugin-jsdoc", | ||
| "eslint-plugin-prefer-arrow", | ||
| "eslint-plugin-react", | ||
| "@typescript-eslint", | ||
| ], | ||
| "rules": { | ||
| "@typescript-eslint/adjacent-overload-signatures": "error", | ||
| "@typescript-eslint/array-type": "off", | ||
| "@typescript-eslint/ban-types": "off", | ||
| "@typescript-eslint/consistent-type-assertions": "error", | ||
| "@typescript-eslint/dot-notation": "off", | ||
| "@typescript-eslint/indent": "off", | ||
| "@typescript-eslint/member-delimiter-style": [ | ||
| "off", | ||
| { | ||
| "multiline": { | ||
| "delimiter": "none", | ||
| "requireLast": true | ||
| }, | ||
| "singleline": { | ||
| "delimiter": "semi", | ||
| "requireLast": false | ||
| } | ||
| } | ||
| ], | ||
| "@typescript-eslint/member-ordering": "off", | ||
| "@typescript-eslint/naming-convention": "off", | ||
| "@typescript-eslint/no-empty-function": "error", | ||
| "@typescript-eslint/no-empty-interface": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-misused-new": "error", | ||
| "@typescript-eslint/no-namespace": "error", | ||
| "@typescript-eslint/no-parameter-properties": "off", | ||
| "@typescript-eslint/no-shadow": [ | ||
| "error", | ||
| { | ||
| "hoist": "all" | ||
| } | ||
| ], | ||
| "@typescript-eslint/no-this-alias": "error", | ||
| "@typescript-eslint/no-unused-expressions": "off", | ||
| "@typescript-eslint/no-use-before-define": "off", | ||
| "@typescript-eslint/no-var-requires": "error", | ||
| "@typescript-eslint/prefer-for-of": "error", | ||
| "@typescript-eslint/prefer-function-type": "error", | ||
| "@typescript-eslint/prefer-namespace-keyword": "error", | ||
| "@typescript-eslint/quotes": "off", | ||
| "@typescript-eslint/semi": [ | ||
| "off", | ||
| null | ||
| ], | ||
| "@typescript-eslint/triple-slash-reference": [ | ||
| "error", | ||
| { | ||
| "path": "always", | ||
| "types": "prefer-import", | ||
| "lib": "always" | ||
| } | ||
| ], | ||
| "@typescript-eslint/type-annotation-spacing": "off", | ||
| "@typescript-eslint/unified-signatures": "error", | ||
| "arrow-parens": [ | ||
| "off", | ||
| "always" | ||
| ], | ||
| "brace-style": [ | ||
| "off", | ||
| "off" | ||
| ], | ||
| "comma-dangle": "off", | ||
| "complexity": "off", | ||
| "constructor-super": "error", | ||
| "curly": "error", | ||
| "dot-notation": "off", | ||
| "eol-last": "off", | ||
| "eqeqeq": [ | ||
| "error", | ||
| "smart" | ||
| ], | ||
| "guard-for-in": "error", | ||
| "id-blacklist": "off", | ||
| "id-match": "off", | ||
| "import/no-extraneous-dependencies": [ | ||
| "error" | ||
| ], | ||
| "import/no-internal-modules": "off", | ||
| "import/order": "off", | ||
| "indent": "off", | ||
| "jsdoc/check-alignment": "error", | ||
| "jsdoc/check-indentation": "error", | ||
| "jsdoc/newline-after-description": "error", | ||
| "linebreak-style": "off", | ||
| "max-classes-per-file": "off", | ||
| "max-len": "off", | ||
| "new-parens": "off", | ||
| "newline-per-chained-call": "off", | ||
| "no-bitwise": "off", | ||
| "no-caller": "error", | ||
| "no-cond-assign": "error", | ||
| "no-console": "off", | ||
| "no-debugger": "error", | ||
| "no-duplicate-case": "error", | ||
| "no-duplicate-imports": "error", | ||
| "no-empty": "error", | ||
| "no-eval": "error", | ||
| "no-extra-bind": "error", | ||
| "no-extra-semi": "off", | ||
| "no-fallthrough": "off", | ||
| "no-invalid-this": "off", | ||
| "no-irregular-whitespace": "off", | ||
| "no-multiple-empty-lines": "off", | ||
| "no-new-func": "error", | ||
| "no-new-wrappers": "error", | ||
| "no-redeclare": "error", | ||
| "no-return-await": "error", | ||
| "no-sequences": "error", | ||
| "no-sparse-arrays": "error", | ||
| "no-template-curly-in-string": "error", | ||
| "no-throw-literal": "error", | ||
| "no-trailing-spaces": "off", | ||
| "no-undef-init": "error", | ||
| "no-underscore-dangle": "off", | ||
| "no-unsafe-finally": "error", | ||
| "no-unused-expressions": "off", | ||
| "no-unused-labels": "error", | ||
| "no-use-before-define": "off", | ||
| "no-var": "error", | ||
| "object-shorthand": "error", | ||
| "one-var": [ | ||
| "error", | ||
| "never" | ||
| ], | ||
| "padded-blocks": [ | ||
| "off", | ||
| { | ||
| "blocks": "never" | ||
| }, | ||
| { | ||
| "allowSingleLineBlocks": true | ||
| } | ||
| ], | ||
| "prefer-arrow/prefer-arrow-functions": "error", | ||
| "prefer-const": "error", | ||
| "prefer-object-spread": "error", | ||
| "quote-props": "off", | ||
| "quotes": "off", | ||
| "radix": "error", | ||
| "react/jsx-curly-spacing": "off", | ||
| "react/jsx-equals-spacing": "off", | ||
| "react/jsx-tag-spacing": [ | ||
| "off", | ||
| { | ||
| "afterOpening": "allow", | ||
| "closingSlash": "allow" | ||
| } | ||
| ], | ||
| "react/jsx-wrap-multilines": "off", | ||
| "semi": "off", | ||
| "space-before-blocks": "error", | ||
| "space-before-function-paren": "off", | ||
| "space-in-parens": [ | ||
| "off", | ||
| "never" | ||
| ], | ||
| "unicorn/prefer-ternary": "off", | ||
| "use-isnan": "error", | ||
| "valid-typeof": "off" | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module.exports = { | ||
| "extends": "../.eslintrc.js" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module.exports = { | ||
| "extends": "../../.eslintrc.js" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "resolveJsonModule": true | ||
| } | ||
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "resolveJsonModule": true | ||
| } | ||
| } | ||
|
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module.exports = { | ||
| "extends": "../../.eslintrc.js" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| module.exports = { | ||
| "extends": "../../.eslintrc.js", | ||
| "parserOptions": { | ||
| "project": "tsconfig.json", | ||
| "sourceType": "module" | ||
| } | ||
| } |
Oops, something went wrong.