Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling new Array with 1 argument doesn't work properly #209

Closed
IovoslavIovchev opened this issue Nov 17, 2019 · 2 comments · Fixed by #328
Closed

Calling new Array with 1 argument doesn't work properly #209

IovoslavIovchev opened this issue Nov 17, 2019 · 2 comments · Fixed by #328
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
v0.8.0

Comments

@IovoslavIovchev
Copy link
Contributor

The spec describes that new Array(5) should create an array with 5 empty elements/slots. Currently, it produces [5].
@IovoslavIovchev IovoslavIovchev added the bug Something isn't working label Nov 17, 2019
@jasonwilliams jasonwilliams mentioned this issue Nov 17, 2019
Closed
@jasonwilliams jasonwilliams added the help wanted Extra attention is needed label Dec 3, 2019
This was referenced Jan 22, 2020
Open
Closed
@nasso
Copy link

nasso commented Feb 15, 2020

I'm working on it!

@nasso
Copy link

nasso commented Feb 15, 2020

@nasso Woops nevermind didn't see the above PR!

@HalidOdat HalidOdat self-assigned this Apr 16, 2020
HalidOdat added a commit to HalidOdat/boa that referenced this issue Apr 17, 2020
@HalidOdat
fix boa-dev#209 "Calling Array with one argument"
901560f
@HalidOdat HalidOdat mentioned this issue Apr 17, 2020
Merged
Razican added a commit that referenced this issue Apr 29, 2020
@HalidOdat @Razican
fix #209 "Calling Array with one argument" (#328)
dd0f967 
* fix issue 209 "Calling Array with one argument"

* Update boa/src/builtins/array/mod.rs

Co-Authored-By: Iban Eguia <razican@protonmail.ch>

* Changed from unimplemented to panic in array

Co-authored-by: Iban Eguia <razican@protonmail.ch>
@Razican Razican added this to the v0.8.0 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

fix #209 "Calling Array with one argument" HalidOdat/boa
5 participants
@Razican @jasonwilliams @HalidOdat @nasso @IovoslavIovchev