Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete when the property is not configurable #1024

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Fix delete when the property is not configurable #1024

merged 2 commits into from
Jan 2, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 1, 2021

This Pull Request fixes an issue with delete when the property to delete is not configurable. In this case, delete should not remove the property from the object, and it should return false.

It changes the following:

  • The execution of the delete operator

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1024 (f0eb2e6) into master (e0a135e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage   60.26%   60.31%   +0.05%     
==========================================
  Files         169      169              
  Lines       11412    11418       +6     
==========================================
+ Hits         6877     6887      +10     
+ Misses       4535     4531       -4     
Impacted Files Coverage Δ
boa/src/syntax/ast/node/operator/unary_op/mod.rs 69.84% <100.00%> (+1.50%) ⬆️
boa/src/builtins/function/mod.rs 75.72% <0.00%> (ø)
boa/src/environment/global_environment_record.rs 21.05% <0.00%> (ø)
boa/src/environment/object_environment_record.rs 23.72% <0.00%> (ø)
boa/src/environment/lexical_environment.rs 67.61% <0.00%> (+0.31%) ⬆️
boa/src/environment/function_environment_record.rs 34.78% <0.00%> (+0.57%) ⬆️
.../src/environment/declarative_environment_record.rs 41.11% <0.00%> (+0.66%) ⬆️
boa/src/object/internal_methods.rs 62.93% <0.00%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a135e...f0eb2e6. Read the comment docs.

@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Jan 2, 2021
@Razican Razican added this to the v0.11.0 milestone Jan 2, 2021
@Razican
Copy link
Member

Razican commented Jan 2, 2021

Nice conformance improvement!

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 23,335 23,800 +465
Ignored 15,585 15,585 0
Failed 39,573 39,108 -465
Panics 364 364 0
Conformance 29.73 30.32 +0.59%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Co-authored-by: Halid Odat <halidodat@gmail.com>
@Razican Razican requested a review from HalidOdat January 2, 2021 11:46
@Razican Razican merged commit 14ef50c into boa-dev:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants