Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute configurable of the length property of arguments #1071

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fix attribute configurable of the length property of arguments #1071

merged 1 commit into from
Jan 15, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 14, 2021

This PR fixes the attribute configurable of the length property of arguments.

@tofpie tofpie added the bug Something isn't working label Jan 14, 2021
@tofpie tofpie added this to the v0.12.0 milestone Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1071 (d0b42e7) into master (aa03a7d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1071   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         176      176           
  Lines       12389    12389           
=======================================
  Hits         7272     7272           
  Misses       5117     5117           
Impacted Files Coverage Δ
boa/src/builtins/function/mod.rs 69.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa03a7d...d0b42e7. Read the comment docs.

@Razican
Copy link
Member

Razican commented Jan 15, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 24,795 24,799 +4
Ignored 15,587 15,587 0
Failed 38,115 38,111 -4
Panics 26 26 0
Conformance 31.59 31.59 +0.01%

@Razican Razican added the builtins PRs and Issues related to builtins/intrinsics label Jan 15, 2021
@Razican Razican merged commit 797092c into boa-dev:master Jan 15, 2021
@tofpie tofpie deleted the fix-arg-length branch January 15, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants