Fix line terminator in string literal #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevancc
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 58.74% 58.81% +0.06%
==========================================
Files 176 176
Lines 12477 12467 -10
==========================================
+ Hits 7330 7332 +2
+ Misses 5147 5135 -12
Continue to review full report at Codecov.
|
jevancc
force-pushed
the
fix-line-terminator
branch
from
a1bfba4
to
8d6eb54
Compare
|
Numbers are looking good :) Test262 conformance changes:
|
jevancc
changed the title
RageKnify
requested changes
Jan 21, 2021
There was a problem hiding this comment.
I'm a little confused by some of the changes in the tests. The implementation seems good.
The test262 numbers have changed, latest commit reports:
Test262 conformance changes:
| Test result | master count | PR count | difference |
|---|---|---|---|
| Total | 78,497 | 78,497 | 0 |
| Passed | 24,850 | 24,862 | +12 |
| Ignored | 15,587 | 15,587 | 0 |
| Failed | 38,060 | 38,048 | -12 |
| Panics | 18 | 18 | 0 |
| Conformance | 31.66 | 31.67 | +0.02% |
RageKnify
approved these changes
Jan 21, 2021
RageKnify
requested review from
tofpie,
HalidOdat,
jasonwilliams,
Lan2u and
Razican
tofpie
approved these changes
Jan 21, 2021
Lan2u
approved these changes
Jan 21, 2021
Fix octal escape in string literal Add tests Fix zero escape Fix zero escape lookahead Rename variables Rename helper functions Refactor match arms Fix escape line terminator sequence Fix single character escape Fix line terminator and escape followed by unicode char Fix broken tests Add NonOctalDecimalEscapeSequence Fix comment Refactor Modify error message Add tests Rename tests Add test for error Add comments for unsafe bytes to str Update boa/src/syntax/lexer/string.rs Co-authored-by: tofpie <75836434+tofpie@users.noreply.github.com> Minor refactor Remove unsafe bytes to str Fix panic when reading invalid utf-8 chars Refactor string literal Support invalid utf-8 chars in string literal input Add cook function for template literal Fix line continuation bug Add methods for utf16 buffer trait Add trait comments Add error message for template literal Add and fix comments Hide unused exported function and modify tests Fix bug Fix merge bug
jevancc
force-pushed
the
fix-line-terminator
branch
from
6031e6e
to
8937bb2
Compare
This was referenced Jan 27, 2021
Razican
pushed a commit
that referenced
this pull request
May 22, 2021
Fix octal escape in string literal Add tests Fix zero escape Fix zero escape lookahead Rename variables Rename helper functions Refactor match arms Fix escape line terminator sequence Fix single character escape Fix line terminator and escape followed by unicode char Fix broken tests Add NonOctalDecimalEscapeSequence Fix comment Refactor Modify error message Add tests Rename tests Add test for error Add comments for unsafe bytes to str Update boa/src/syntax/lexer/string.rs Co-authored-by: tofpie <75836434+tofpie@users.noreply.github.com> Minor refactor Remove unsafe bytes to str Fix panic when reading invalid utf-8 chars Refactor string literal Support invalid utf-8 chars in string literal input Add cook function for template literal Fix line continuation bug Add methods for utf16 buffer trait Add trait comments Add error message for template literal Add and fix comments Hide unused exported function and modify tests Fix bug Fix merge bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1083.
It changes the following:
"\����")Since template literal now has its own method to process characters, I unexported the method
StringLiteral::take_string_charactersand removeStringTerminator::End. Some tests ontake_string_charactersare modified to test on lexer directly.