Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSON[ @@toStringTag ] #1224

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Implement JSON[ @@toStringTag ]

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels May 4, 2021
@HalidOdat HalidOdat added this to the v0.12.0 milestone May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 25,501 25,515 +14
Ignored 15,587 15,587 0
Failed 37,409 37,395 -14
Panics 12 13 +1
Conformance 32.49 32.50 +0.02%

@github-actions
Copy link

github-actions bot commented May 4, 2021

Benchmark for 0552c82

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 318.4±7.28ns 320.7±8.44ns -0.72%
Arithmetic operations (Full) 247.6±11.70µs 247.2±4.96µs +0.16%
Array access (Execution) 6.0±0.15µs 6.0±0.28µs 0.00%
Array access (Full) 270.2±5.57µs 267.8±30.66µs +0.90%
Array creation (Execution) 2.5±0.11ms 2.5±0.08ms 0.00%
Array creation (Full) 2.7±0.07ms 2.7±0.07ms 0.00%
Array pop (Execution) 805.7±21.20µs 806.0±30.09µs -0.04%
Array pop (Full) 1239.0±41.45µs 1226.3±40.53µs +1.04%
Boolean Object Access (Execution) 5.3±0.16µs 5.2±0.20µs +1.92%
Boolean Object Access (Full) 263.6±8.58µs 258.7±6.35µs +1.89%
Clean js (Execution) 620.9±16.77µs 619.1±17.74µs +0.29%
Clean js (Full) 896.0±27.51µs 883.0±18.18µs +1.47%
Clean js (Parser) 40.5±1.00µs 41.3±0.92µs -1.94%
Create Realm 412.0±14.49ns 407.6±14.91ns +1.08%
Dynamic Object Property Access (Execution) 5.0±0.26µs 4.9±0.13µs +2.04%
Dynamic Object Property Access (Full) 265.9±7.24µs 262.4±18.58µs +1.33%
Expression (Parser) 6.2±0.18µs 6.1±0.16µs +1.64%
Fibonacci (Execution) 795.2±26.55µs 802.5±15.76µs -0.91%
Fibonacci (Full) 1015.8±24.96µs 1023.6±29.69µs -0.76%
For loop (Execution) 20.8±0.57µs 21.2±0.55µs -1.89%
For loop (Full) 281.0±8.04µs 276.8±7.25µs +1.52%
For loop (Parser) 19.2±0.56µs 19.4±0.94µs -1.03%
Goal Symbols (Parser) 13.4±0.31µs 13.5±0.28µs -0.74%
Hello World (Parser) 3.6±0.11µs 3.6±0.10µs 0.00%
Long file (Parser) 712.3±50.83ns 722.4±42.34ns -1.40%
Mini js (Execution) 551.2±19.45µs 547.4±10.71µs +0.69%
Mini js (Full) 845.2±29.03µs 819.9±18.29µs +3.09%
Mini js (Parser) 35.6±1.37µs 36.0±2.11µs -1.11%
Number Object Access (Execution) 4.1±0.11µs 3.9±0.18µs +5.13%
Number Object Access (Full) 258.4±9.13µs 253.8±15.88µs +1.81%
Object Creation (Execution) 4.3±0.20µs 4.1±0.16µs +4.88%
Object Creation (Full) 260.1±10.72µs 257.4±11.20µs +1.05%
RegExp (Execution) 9.1±0.23µs 9.1±0.39µs 0.00%
RegExp (Full) 268.5±6.25µs 265.2±13.63µs +1.24%
RegExp Literal (Execution) 10.4±0.32µs 10.4±0.35µs 0.00%
RegExp Literal (Full) 272.0±7.74µs 272.2±10.94µs -0.07%
RegExp Literal Creation (Execution) 9.1±0.31µs 9.0±0.26µs +1.11%
RegExp Literal Creation (Full) 269.8±19.42µs 258.3±12.01µs +4.45%
Static Object Property Access (Execution) 4.5±0.10µs 4.4±0.13µs +2.27%
Static Object Property Access (Full) 262.0±5.92µs 258.3±7.98µs +1.43%
String Object Access (Execution) 7.2±0.30µs 7.1±0.26µs +1.41%
String Object Access (Full) 268.4±9.86µs 266.3±15.93µs +0.79%
String comparison (Execution) 6.2±0.26µs 6.1±0.21µs +1.64%
String comparison (Full) 266.1±8.69µs 260.9±12.56µs +1.99%
String concatenation (Execution) 5.1±0.16µs 5.0±0.17µs +2.00%
String concatenation (Full) 262.5±13.27µs 249.8±10.68µs +5.08%
String copy (Execution) 3.9±0.16µs 3.8±0.24µs +2.63%
String copy (Full) 253.9±8.40µs 250.1±25.09µs +1.52%
Symbols (Execution) 3.3±0.08µs 3.3±0.29µs 0.00%
Symbols (Full) 245.0±11.19µs 235.3±4.68µs +4.12%

@HalidOdat HalidOdat merged commit 26b6223 into master May 7, 2021
@HalidOdat HalidOdat deleted the feature/json-tostringtag-symbol branch May 7, 2021 20:57
Razican added a commit that referenced this pull request May 22, 2021
Razican added a commit that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant