Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Math[ @@toStringTag ] #1225

Merged
merged 1 commit into from
May 7, 2021
Merged

Implement Math[ @@toStringTag ] #1225

merged 1 commit into from
May 7, 2021

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Implement Math[ @@toStringTag ]

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels May 4, 2021
@HalidOdat HalidOdat added this to the v0.12.0 milestone May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 25,501 25,515 +14
Ignored 15,587 15,587 0
Failed 37,409 37,395 -14
Panics 12 13 +1
Conformance 32.49 32.50 +0.02%

@github-actions
Copy link

github-actions bot commented May 4, 2021

Benchmark for 5c1b005

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 359.4±4.77ns 365.4±5.92ns -1.64%
Arithmetic operations (Full) 260.3±13.61µs 247.8±2.13µs +5.04%
Array access (Execution) 6.1±0.06µs 6.1±0.07µs 0.00%
Array access (Full) 266.1±6.71µs 271.5±2.68µs -1.99%
Array creation (Execution) 3.0±0.01ms 2.9±0.08ms +3.45%
Array creation (Full) 3.1±0.07ms 3.1±0.05ms 0.00%
Array pop (Execution) 943.0±9.24µs 944.7±10.30µs -0.18%
Array pop (Full) 1518.9±93.29µs 1394.1±22.08µs +8.95%
Boolean Object Access (Execution) 5.3±0.07µs 5.3±0.09µs 0.00%
Boolean Object Access (Full) 266.1±4.49µs 266.4±3.50µs -0.11%
Clean js (Execution) 667.7±10.31µs 708.8±44.23µs -5.80%
Clean js (Full) 961.1±15.15µs 1044.0±64.66µs -7.94%
Clean js (Parser) 43.2±0.54µs 43.4±0.43µs -0.46%
Create Realm 465.2±5.80ns 455.2±4.53ns +2.20%
Dynamic Object Property Access (Execution) 5.0±0.05µs 5.5±0.47µs -9.09%
Dynamic Object Property Access (Full) 280.3±20.39µs 268.5±4.53µs +4.39%
Expression (Parser) 7.0±0.07µs 7.1±0.35µs -1.41%
Fibonacci (Execution) 821.2±37.73µs 774.3±7.97µs +6.06%
Fibonacci (Full) 1021.9±24.64µs 1061.0±4.74µs -3.69%
For loop (Execution) 21.0±0.39µs 21.6±0.23µs -2.78%
For loop (Full) 286.1±3.01µs 289.1±2.01µs -1.04%
For loop (Parser) 20.7±0.18µs 21.8±1.47µs -5.05%
Goal Symbols (Parser) 14.5±0.19µs 14.5±0.17µs 0.00%
Hello World (Parser) 4.0±0.08µs 4.0±0.04µs 0.00%
Long file (Parser) 828.4±54.50ns 787.9±12.07ns +5.14%
Mini js (Execution) 589.6±12.17µs 593.9±9.90µs -0.72%
Mini js (Full) 921.2±72.00µs 886.6±9.54µs +3.90%
Mini js (Parser) 39.9±2.38µs 37.6±0.71µs +6.12%
Number Object Access (Execution) 4.2±0.06µs 4.3±0.25µs -2.33%
Number Object Access (Full) 262.1±2.18µs 273.3±15.37µs -4.10%
Object Creation (Execution) 4.2±0.04µs 4.2±0.10µs 0.00%
Object Creation (Full) 262.2±2.88µs 265.8±3.48µs -1.35%
RegExp (Execution) 9.4±0.15µs 9.9±0.09µs -5.05%
RegExp (Full) 269.3±7.29µs 273.1±1.70µs -1.39%
RegExp Literal (Execution) 11.5±0.58µs 11.5±0.09µs 0.00%
RegExp Literal (Full) 268.9±9.76µs 276.8±0.85µs -2.85%
RegExp Literal Creation (Execution) 9.3±0.13µs 9.9±0.09µs -6.06%
RegExp Literal Creation (Full) 267.2±3.42µs 277.6±21.78µs -3.75%
Static Object Property Access (Execution) 4.5±0.06µs 4.4±0.12µs +2.27%
Static Object Property Access (Full) 264.3±4.20µs 262.8±5.74µs +0.57%
String Object Access (Execution) 7.4±0.08µs 7.3±0.14µs +1.37%
String Object Access (Full) 269.3±4.00µs 270.6±4.43µs -0.48%
String comparison (Execution) 6.5±0.10µs 6.5±0.08µs 0.00%
String comparison (Full) 269.2±2.76µs 271.3±2.98µs -0.77%
String concatenation (Execution) 5.1±0.07µs 5.1±0.09µs 0.00%
String concatenation (Full) 258.5±3.74µs 263.0±4.11µs -1.71%
String copy (Execution) 3.8±0.06µs 4.1±0.26µs -7.32%
String copy (Full) 254.5±3.78µs 252.5±5.33µs +0.79%
Symbols (Execution) 3.4±0.02µs 3.3±0.04µs +3.03%
Symbols (Full) 247.3±2.70µs 260.8±19.46µs -5.18%

Razican
Razican approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

RageKnify
RageKnify approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but the added panic is surprising.

@HalidOdat
Copy link
Member Author

HalidOdat commented May 7, 2021 •
edited
Loading

Code looks fine, but the added panic is surprising.

Yes this is strange. I have seen added panics on PRs that don't touch the rust code, like npm package dependabot updates

@HalidOdat HalidOdat merged commit bee7386 into master May 7, 2021
@HalidOdat HalidOdat deleted the feature/math-tostringtag-symbol branch May 7, 2021 19:03
This was referenced May 7, 2021
Closed
Closed
Closed
Closed
@wylie39 wylie39 mentioned this pull request May 12, 2021
Merged
Razican added a commit that referenced this pull request May 12, 2021
@wylie39 @Razican
Implement Map.prototype[ @@toStringTag ] (#1249)
a0be5cd 
* Implement Map.prototype[ @@toStringTag ]

This Implements Map.prototype[ @@toStringTag ] 

This is the same as #1225

* Update boa/src/builtins/map/mod.rs

Co-authored-by: Iban Eguia <razican@protonmail.ch>

Co-authored-by: Iban Eguia <razican@protonmail.ch>
Razican added a commit that referenced this pull request May 22, 2021
@Razican
Implement Math[ @@toStringTag ] (#1225)
326c7a3
Razican added a commit that referenced this pull request May 22, 2021
@wylie39 @Razican
Implement Map.prototype[ @@toStringTag ] (#1249)
2dceceb 
* Implement Map.prototype[ @@toStringTag ]

This Implements Map.prototype[ @@toStringTag ] 

This is the same as #1225

* Update boa/src/builtins/map/mod.rs

Co-authored-by: Iban Eguia <razican@protonmail.ch>

Co-authored-by: Iban Eguia <razican@protonmail.ch>
Razican added a commit that referenced this pull request May 22, 2021
@Razican
Implement Math[ @@toStringTag ] (#1225)
5d4497b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@RageKnify RageKnify RageKnify approved these changes

@0x7D2B 0x7D2B Awaiting requested review from 0x7D2B

@Lan2u Lan2u Awaiting requested review from Lan2u

@tofpie tofpie Awaiting requested review from tofpie

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HalidOdat @Razican @jasonwilliams @RageKnify