Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boa): fixes unshift maximum size #1348

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 19, 2021

This Pull Request fixes/closes #1306.

It changes the following:

  • throws TypeErrException according to spec for len + argCount > MAX_SAFE_INTEGER

- throws TypeErrException according to spec for len + argCount >
MAX_SAFE_INTEGER

Closes boa-dev#1306
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good :) check my comment in case it makes sense

boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
@Razican
Copy link
Member

Razican commented Jun 20, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,940 26,949 +9
Ignored 15,628 15,622 -6
Failed 36,329 36,326 -3
Panics 1 0 -1
Conformance 34.15% 34.16% +0.01%
Fixed tests:
test/built-ins/Array/prototype/unshift/throws-if-integer-limit-exceeded.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/unshift/throws-if-integer-limit-exceeded.js (previously Ignored)
test/built-ins/Array/prototype/splice/throws-if-integer-limit-exceeded.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/splice/throws-if-integer-limit-exceeded.js (previously Ignored)
test/built-ins/Array/prototype/push/S15.4.4.7_A2_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/push/S15.4.4.7_A2_T2.js (previously Failed)
test/built-ins/Array/prototype/push/throws-if-integer-limit-exceeded.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/push/throws-if-integer-limit-exceeded.js (previously Ignored)
test/built-ins/Map/prototype/keys/returns-iterator.js (previously Panic)

@Razican
Copy link
Member

Razican commented Jun 20, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,940 26,945 +5
Ignored 15,628 15,622 -6
Failed 36,329 36,330 +1
Panics 1 0 -1
Conformance 34.15% 34.15% +0.01%
Fixed tests:
test/built-ins/Array/prototype/unshift/throws-if-integer-limit-exceeded.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/unshift/throws-if-integer-limit-exceeded.js (previously Ignored)
test/built-ins/Array/prototype/splice/throws-if-integer-limit-exceeded.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/splice/throws-if-integer-limit-exceeded.js (previously Ignored)
test/built-ins/Map/prototype/keys/returns-iterator.js (previously Panic)
Broken tests:
test/built-ins/Array/prototype/push/throws-if-integer-limit-exceeded.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/push/throws-if-integer-limit-exceeded.js (previously Ignored)

It seems there is one new test broken (in both strict and non-strict mode), could you check why?

- adds limit on push
- rephrases message

Closes boa-dev#1306
@Razican Razican merged commit 79948b7 into boa-dev:master Jun 21, 2021
@neeldug neeldug deleted the fix-throw-if-int-limt-exceeded branch June 21, 2021 10:01
@Razican Razican added this to the v0.13.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Test262 tests run forever
3 participants