Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract PropertyMap struct from Object #1425

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Extract PropertyMap struct from Object #1425

merged 1 commit into from
Aug 6, 2021

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jul 22, 2021 •
edited
Loading

Refactors object properties from Object by creating a PropertyMap struct.

It changes the following:

  • Adds the PropertyMap struct
  • Changes Object to contain a properties field of type PropertyMap
  • Adds a properties() -> &PropertyMap function to Object
  • Renames iter.rs to property_map.rs

@jedel1043 jedel1043 force-pushed the property_map branch 2 times, most recently from a9ad100 to c572930 Compare July 22, 2021 22:44
RageKnify
RageKnify approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction to ease the understanding of Object, compiler should inline where necessary.

HalidOdat
HalidOdat approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

just needs a rebase.

@HalidOdat HalidOdat added this to the v0.13.0 milestone Aug 6, 2021
@HalidOdat HalidOdat merged commit f331694 into boa-dev:master Aug 6, 2021
@jedel1043 jedel1043 deleted the property_map branch August 6, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@RageKnify RageKnify RageKnify approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @HalidOdat @RageKnify