Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract operation CreateArrayFromList #1485

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

jedel1043
Copy link
Member

This Pull Request implements the abstract operation CreateArrayFromList.

It changes the following:

  • Creates new function Array::create_array_from_list
  • Replaces calls to other functions with calls to the above.
  • Removes the function Array::construct_array, as it is equivalent to create_array_from_list

@HalidOdat HalidOdat added this to the v0.13.0 milestone Aug 20, 2021
@HalidOdat
Copy link
Member

Test result master count PR count difference
Total 78,897 78,897 0
Passed 29,766 29,766 0
Ignored 15,612 15,612 0
Failed 33,519 33,519 0
Panics 2 2 0
Conformance 37.73% 37.73% 0.00%

@HalidOdat HalidOdat merged commit 0f380a9 into boa-dev:master Aug 20, 2021
@jedel1043 jedel1043 deleted the create_array branch August 20, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants