Restrict `ClosureFunction` to only `Copy` closures #1518

jedel1043 · 2021-08-26T22:43:10Z

This Pull Request fixes/closes #1515.

It changes the following:

Refactors ClosureFunction into a proper trait, with an additional Copy bound.
Replaces Rc<ClosureFunction> with Box<dyn ClosureFunction> inside Function.
Documents parts of the function module.

Razican

Looks pretty good! I will check a bit more what dyn_clone does :)

boa/src/builtins/function/mod.rs

Razican reviewed Aug 27, 2021

View reviewed changes

boa/src/builtins/function/mod.rs Outdated Show resolved Hide resolved

Razican requested review from HalidOdat and RageKnify August 27, 2021 06:01

jedel1043 force-pushed the copy_closures branch from ec13d94 to 43d6df6 Compare August 27, 2021 06:05

Razican approved these changes Aug 27, 2021

View reviewed changes

Razican added this to the v0.13.0 milestone Aug 27, 2021

Restrict ClosureFunction to only Copy closures

57592c0

jedel1043 force-pushed the copy_closures branch from 43d6df6 to 57592c0 Compare August 27, 2021 15:26

jedel1043 mentioned this pull request Aug 27, 2021

Implement arguments exotic objects #1522

Merged

jedel1043 force-pushed the copy_closures branch from 69b9b0a to 57592c0 Compare August 28, 2021 01:40

jedel1043 mentioned this pull request Aug 28, 2021

Allow moving NativeObject variables into closures as external captures #1523

Merged

HalidOdat approved these changes Aug 28, 2021

View reviewed changes

HalidOdat merged commit f9a82b4 into boa-dev:master Aug 28, 2021

jedel1043 deleted the copy_closures branch August 28, 2021 19:00

Provide feedback