Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Math builtin object #1584

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Refactor the Math builtin object #1584

merged 2 commits into from
Sep 21, 2021

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Sep 17, 2021

This Pull Request changes the following:

  • Makes the methods max, min, log, log2 and log10 spec compliant.
  • Documents all Math builtin methods.
  • Improves the readability with get_or_undefined.

@github-actions
Copy link

github-actions bot commented Sep 17, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 80,918 80,918 0
Passed 33,178 33,192 +14
Ignored 15,898 15,898 0
Failed 31,842 31,828 -14
Panics 0 0 0
Conformance 41.00% 41.02% +0.02%
Fixed tests (14):
test/built-ins/Math/log10/Log10-specialVals.js [strict mode] (previously Failed)
test/built-ins/Math/log10/Log10-specialVals.js (previously Failed)
test/built-ins/Math/log/S15.8.2.10_A3.js [strict mode] (previously Failed)
test/built-ins/Math/log/S15.8.2.10_A3.js (previously Failed)
test/built-ins/Math/max/S15.8.2.11_A2.js [strict mode] (previously Failed)
test/built-ins/Math/max/S15.8.2.11_A2.js (previously Failed)
test/built-ins/Math/max/15.8.2.11-1.js [strict mode] (previously Failed)
test/built-ins/Math/max/15.8.2.11-1.js (previously Failed)
test/built-ins/Math/log2/log2-basicTests.js [strict mode] (previously Failed)
test/built-ins/Math/log2/log2-basicTests.js (previously Failed)
test/built-ins/Math/min/S15.8.2.12_A2.js [strict mode] (previously Failed)
test/built-ins/Math/min/S15.8.2.12_A2.js (previously Failed)
test/built-ins/Math/min/15.8.2.12-1.js [strict mode] (previously Failed)
test/built-ins/Math/min/15.8.2.12-1.js (previously Failed)

@jedel1043 jedel1043 force-pushed the math_docs branch 3 times, most recently from 75db1c7 to 4c69db7 Compare September 17, 2021 06:25
@jedel1043 jedel1043 changed the title Document the Math builtin object Refactor the Math builtin object Sep 17, 2021
@jedel1043 jedel1043 added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics documentation update documentation labels Sep 17, 2021
Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small corrections

@RageKnify RageKnify merged commit dd84439 into master Sep 21, 2021
@RageKnify RageKnify deleted the math_docs branch September 21, 2021 13:01
@raskad raskad mentioned this pull request Sep 28, 2021
@Razican Razican added this to the v0.13.0 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants