Implement Symbol.prototype.valueOf
#1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
jedel1043
requested changes
Oct 3, 2021
boa/src/builtins/symbol/mod.rs
Outdated
Comment on lines
231
to
233
| // valueOf a symbol is itself | ||
| let symbol = Self::this_symbol_value(this, context)?; | ||
| Ok(JsValue::Symbol(symbol)) |
There was a problem hiding this comment.
Can you add a comment with the spec steps? Even if it's only a single one :)
jedel1043
added
bug
Include steps from ECMAScript spec
jedel1043
approved these changes
Oct 3, 2021
jedel1043
changed the title
jedel1043
changed the title
Symbol.prototype.valueOf
HalidOdat
approved these changes
Oct 3, 2021
jedel1043
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hle0 91701075+hle0@users.noreply.github.com
This Pull Request fixes/closes #1617 .
It changes the following:
valueOfis defined differently forSymbolso thatSymbol('s').valueOf() == Symbol('s'), as per the spec.