[Merged by Bors] - Add limited console.trace implementation #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwilliams
approved these changes
Oct 4, 2021
RageKnify
reviewed
Oct 24, 2021
|
|
||
| #[cfg(not(feature = "vm"))] | ||
| fn get_stack_trace(_: &mut Context) -> Vec<String> { | ||
| vec![] |
There was a problem hiding this comment.
Should leave a TODO comment here so that it is easy to spot
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
This Pull Request partially fixes #307. It changes the following: - Implements limited `console.trace` functionality by dumping stack trace. Since `console.trace`'s output is supposed to be implementation-specific according to the technical specification, it should be technically correct 😀 Any hints about potential improvements are welcome!
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
This Pull Request partially fixes #307. It changes the following: - Implements limited `console.trace` functionality by dumping stack trace. Since `console.trace`'s output is supposed to be implementation-specific according to the technical specification, it should be technically correct 😀 Any hints about potential improvements are welcome!
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request partially fixes #307.
It changes the following:
console.tracefunctionality by dumping stack trace. Sinceconsole.trace's output is supposed to be implementation-specific according to the technical specification, it should be technically correct 😀 Any hints about potential improvements are welcome!