Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete operator in the vm #1649

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 7, 2021

It changes the following:

  • Implements the delete operator in the vm
  • Remove unneeded syntax error in delete operator execution

@raskad raskad added the vm Issues and PRs related to the Boa Virtual Machine. label Oct 7, 2021
@raskad raskad added this to the v0.14.0 milestone Oct 7, 2021
@raskad
Copy link
Member Author

raskad commented Oct 7, 2021

Fixed one test for the tree walking interpreter but that should not really be the focus.

Test262 conformance changes:

Test result main count PR count difference
Total 86,438 86,438 0
Passed 37,456 37,458 +2
Ignored 19,022 19,022 0
Failed 29,960 29,958 -2
Panics 0 0 0
Conformance 43.33% 43.34% +0.00%
Fixed tests (2):
test/language/global-code/S10.1.7_A1_T1.js [strict mode] (previously Failed)
test/language/global-code/S10.1.7_A1_T1.js (previously Failed)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

boa/src/bytecompiler.rs Outdated Show resolved Hide resolved
boa/src/vm/code_block.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat merged commit b624be6 into boa-dev:main Oct 11, 2021
@HalidOdat HalidOdat added the enhancement New feature or request label Oct 11, 2021
@raskad raskad deleted the vm-delete branch October 14, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants