[Merged by Bors] - Feature JsArray
#1746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
HalidOdat
requested review from
jedel1043,
raskad,
jasonwilliams,
RageKnify and
Razican
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 55.57% 55.30% -0.28%
==========================================
Files 199 200 +1
Lines 17760 17848 +88
==========================================
Hits 9871 9871
- Misses 7889 7977 +88
Continue to review full report at Codecov.
|
Test262 conformance changesVM implementation
|
|
Sounds good to me, the exposed API could work quite well. I'm assuming src/object will eventually have all the APIs we plan to expose? |
HalidOdat
force-pushed
the
feature/jsarrayobject
branch
from
ab0a708
to
6d95db1
Compare
Yeah, plan to add others like |
RageKnify
approved these changes
Dec 17, 2021
Razican
approved these changes
Feb 5, 2022
jedel1043
requested changes
Feb 5, 2022
HalidOdat
force-pushed
the
feature/jsarrayobject
branch
2 times, most recently
from
af59c00
to
8a7670e
Compare
Benchmark for 7676a2bClick to view benchmark
|
Benchmark for 3b831ddClick to view benchmark
|
HalidOdat
force-pushed
the
feature/jsarrayobject
branch
from
8a7670e
to
06bfad5
Compare
Benchmark for 07e4868Click to view benchmark
|
jedel1043
requested changes
Feb 18, 2022
HalidOdat
force-pushed
the
feature/jsarrayobject
branch
from
06bfad5
to
3c667fb
Compare
HalidOdat
force-pushed
the
feature/jsarrayobject
branch
from
3c667fb
to
e1c4fec
Compare
Benchmark for ff3f778Click to view benchmark
|
Benchmark for bd05fd5Click to view benchmark
|
|
LGTM! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2022
This PR introduces a new API for JavaScript builtin objects in Rust (such as `Array`, `Map`, `Proxy`, etc). Rather than just expose the raw builtin functions as discussed here #1692 (though having raw API exposed may be nice as well), In this PR we introduce a very light wrapper around the raw API, for a more pleasant user experience. The wrapper implements functions that are specific to the wrapper type (for `Array` this would be methods like `pop`, `push`, etc) as well as implementing `Deref<Target = JsObject>` so we can call `JsObject` functions without converting to `JsObject` and `Into<JsValue>` for easy to `JsValue` conversions. Please check `jsarray.rs` in the `examples`
|
Pull request successfully merged into main. Build succeeded: |
Razican
pushed a commit
that referenced
this pull request
Feb 21, 2022
This PR introduces a new API for JavaScript builtin objects in Rust (such as `Array`, `Map`, `Proxy`, etc). Rather than just expose the raw builtin functions as discussed here #1692 (though having raw API exposed may be nice as well), In this PR we introduce a very light wrapper around the raw API, for a more pleasant user experience. The wrapper implements functions that are specific to the wrapper type (for `Array` this would be methods like `pop`, `push`, etc) as well as implementing `Deref<Target = JsObject>` so we can call `JsObject` functions without converting to `JsObject` and `Into<JsValue>` for easy to `JsValue` conversions. Please check `jsarray.rs` in the `examples`
This was referenced Apr 3, 2022
bors bot
pushed a commit
that referenced
this pull request
May 1, 2022
This PR adds `JsFunction` wrapper around JavaScript `Function` object, like #1746 With this PR we can distinguish between regular object and function object when we need, such as accessors (because they always need to be functions), predicates in `JsArray` methods like `map`, `find`, etc. With this abstraction we leverage the type system of rust which cleans the API making intentions clear. It changes the following: - Make methods that take predicate/callback function take `JsFunction`s - Make `.accessor()` and `.static_accessor()` take `Option<JsFunction>` - Make `FunctionBuilder` return `JsFunction` - Make `ConstructorBuilder` return `JsFunction` - Make `ClassBuilder` return `JsFunction`
16 tasks
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This PR adds `JsFunction` wrapper around JavaScript `Function` object, like #1746 With this PR we can distinguish between regular object and function object when we need, such as accessors (because they always need to be functions), predicates in `JsArray` methods like `map`, `find`, etc. With this abstraction we leverage the type system of rust which cleans the API making intentions clear. It changes the following: - Make methods that take predicate/callback function take `JsFunction`s - Make `.accessor()` and `.static_accessor()` take `Option<JsFunction>` - Make `FunctionBuilder` return `JsFunction` - Make `ConstructorBuilder` return `JsFunction` - Make `ClassBuilder` return `JsFunction`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new API for JavaScript builtin objects in Rust (such as
Array,Map,Proxy, etc). Rather than just expose the raw builtin functions as discussed here #1692 (though having raw API exposed may be nice as well), In this PR we introduce a very light wrapper around the raw API, for a more pleasant user experience. The wrapper implements functions that are specific to the wrapper type (forArraythis would be methods likepop,push, etc) as well as implementingDeref<Target = JsObject>so we can callJsObjectfunctions without converting toJsObjectandInto<JsValue>for easy toJsValueconversions.Please check
jsarray.rsin theexamples