Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Copy/paste fix in Proxy error message #1787

Closed
wants to merge 1 commit into from

Conversation

icecream17
Copy link
Contributor

(Really small self-explanatory change - maybe the commit message could be better)

It changes the following:

When calling new Proxy(undefined, {}) the error message now refers to the target undefined instead of the handler {}

Really small self-explanatory change
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1787 (10a2029) into main (5c4d970) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   56.22%   56.22%           
=======================================
  Files         200      200           
  Lines       17081    17081           
=======================================
  Hits         9604     9604           
  Misses       7477     7477           
Impacted Files Coverage Δ
boa/src/builtins/proxy/mod.rs 5.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4d970...10a2029. Read the comment docs.

Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jan 19, 2022
(Really small self-explanatory change - maybe the commit message could be better)

<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel neccesary.
--->

It changes the following:

When calling `new Proxy(undefined, {})` the error message now refers to the target `undefined` instead of the handler `{}`
@bors
Copy link

bors bot commented Jan 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Copy/paste fix in Proxy error message [Merged by Bors] - Copy/paste fix in Proxy error message Jan 19, 2022
@bors bors bot closed this Jan 19, 2022
@icecream17 icecream17 deleted the patch-1 branch January 19, 2022 21:44
@Razican Razican added this to the v0.14.0 milestone Feb 23, 2022
@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants