Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Make Object.getOwnPropertyDescriptors spec compliant #1876

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Fix Object.getOwnPropertyDescriptors() to comply to spec

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Feb 27, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 88,342 88,342 0
Passed 42,933 42,939 +6
Ignored 21,413 21,413 0
Failed 23,996 23,990 -6
Panics 0 0 0
Conformance 48.60% 48.61% +0.01%
Fixed tests (6):
test/built-ins/Object/getOwnPropertyDescriptors/primitive-strings.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptors/primitive-strings.js (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptors/observable-operations.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptors/observable-operations.js (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptors/tamper-with-global-object.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptors/tamper-with-global-object.js (previously Failed)

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #1876 (548f40c) into main (ec78e18) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
- Coverage   46.69%   46.68%   -0.01%     
==========================================
  Files         204      204              
  Lines       16719    16719              
==========================================
- Hits         7807     7806       -1     
- Misses       8912     8913       +1     
Impacted Files Coverage Δ
boa_engine/src/builtins/object/mod.rs 67.77% <100.00%> (ø)
boa_engine/src/object/property_map.rs 21.25% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec78e18...548f40c. Read the comment docs.

@github-actions
Copy link

Benchmark for 4a7b930

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 506.3±2.27ns 500.2±0.51ns -1.20%
Arithmetic operations (Execution) 1986.9±2.32ns 1966.1±2.74ns -1.05%
Arithmetic operations (Parser) 5.2±0.01µs 5.3±0.01µs +1.92%
Array access (Compiler) 1282.2±6.22ns 1232.9±9.88ns -3.84%
Array access (Execution) 9.8±0.05µs 9.7±0.04µs -1.02%
Array access (Parser) 11.5±0.03µs 11.5±0.03µs 0.00%
Array creation (Compiler) 1817.7±4.71ns 1813.4±112.43ns -0.24%
Array creation (Execution) 3.1±0.02ms 3.1±0.01ms 0.00%
Array creation (Parser) 13.0±0.02µs 12.9±0.02µs -0.77%
Array pop (Compiler) 3.9±0.01µs 3.8±0.01µs -2.56%
Array pop (Execution) 1350.8±3.69µs 1358.9±5.26µs +0.60%
Array pop (Parser) 129.0±0.12µs 129.7±0.15µs +0.54%
Boolean Object Access (Compiler) 1112.4±4.09ns 1085.5±4.08ns -2.42%
Boolean Object Access (Execution) 5.8±0.05µs 5.6±0.01µs -3.45%
Boolean Object Access (Parser) 14.0±0.02µs 13.7±0.01µs -2.14%
Clean js (Compiler) 3.4±0.01µs 3.3±0.01µs -2.94%
Clean js (Execution) 1095.6±5.34µs 1092.8±9.13µs -0.26%
Clean js (Parser) 27.9±0.03µs 28.0±0.11µs +0.36%
Create Realm 273.0±0.27ns 268.1±0.90ns -1.79%
Dynamic Object Property Access (Compiler) 1592.0±5.19ns 1601.2±2.45ns +0.58%
Dynamic Object Property Access (Execution) 6.8±0.04µs 6.7±0.03µs -1.47%
Dynamic Object Property Access (Parser) 10.3±0.02µs 10.2±0.03µs -0.97%
Fibonacci (Compiler) 2.3±0.01µs 2.2±0.01µs -4.35%
Fibonacci (Execution) 1776.2±1.94µs 1770.4±1.97µs -0.33%
Fibonacci (Parser) 15.7±0.03µs 15.6±0.02µs -0.64%
For loop (Compiler) 1958.1±7.70ns 1920.5±4.80ns -1.92%
For loop (Execution) 43.3±0.10µs 43.0±0.11µs -0.69%
For loop (Parser) 13.3±0.03µs 13.4±0.02µs +0.75%
Mini js (Compiler) 3.3±0.01µs 3.2±0.01µs -3.03%
Mini js (Execution) 1015.4±22.72µs 998.7±5.17µs -1.64%
Mini js (Parser) 24.3±0.03µs 24.4±0.04µs +0.41%
Number Object Access (Compiler) 1030.1±5.06ns 1030.6±4.70ns +0.05%
Number Object Access (Execution) 4.6±0.02µs 4.5±0.02µs -2.17%
Number Object Access (Parser) 10.8±0.01µs 10.8±0.01µs 0.00%
Object Creation (Compiler) 1368.7±6.06ns 1371.9±6.13ns +0.23%
Object Creation (Execution) 6.1±0.02µs 6.1±0.02µs 0.00%
Object Creation (Parser) 8.9±0.02µs 8.9±0.02µs 0.00%
RegExp (Compiler) 1618.2±6.26ns 1612.6±2.98ns -0.35%
RegExp (Execution) 12.2±0.07µs 12.5±0.04µs +2.46%
RegExp (Parser) 9.7±0.01µs 9.7±0.01µs 0.00%
RegExp Creation (Compiler) 1417.2±5.25ns 1375.1±5.88ns -2.97%
RegExp Creation (Execution) 9.0±0.03µs 9.4±0.06µs +4.44%
RegExp Creation (Parser) 8.1±0.01µs 8.0±0.01µs -1.23%
RegExp Literal (Compiler) 1611.3±0.96ns 1616.9±9.33ns +0.35%
RegExp Literal (Execution) 12.2±0.08µs 12.5±0.04µs +2.46%
RegExp Literal (Parser) 7.8±0.01µs 7.9±0.03µs +1.28%
RegExp Literal Creation (Compiler) 1394.1±5.59ns 1394.4±5.81ns +0.02%
RegExp Literal Creation (Execution) 9.0±0.03µs 9.5±0.04µs +5.56%
RegExp Literal Creation (Parser) 6.2±0.01µs 6.2±0.01µs 0.00%
Static Object Property Access (Compiler) 1407.1±5.53ns 1382.5±5.86ns -1.75%
Static Object Property Access (Execution) 6.3±0.02µs 6.3±0.03µs 0.00%
Static Object Property Access (Parser) 9.6±0.02µs 9.5±0.02µs -1.04%
String Object Access (Compiler) 1472.4±6.75ns 1452.4±7.58ns -1.36%
String Object Access (Execution) 7.5±0.04µs 7.5±0.02µs 0.00%
String Object Access (Parser) 13.6±0.01µs 13.5±0.01µs -0.74%
String comparison (Compiler) 2.1±0.01µs 2.1±0.01µs 0.00%
String comparison (Execution) 5.9±0.01µs 5.9±0.02µs 0.00%
String comparison (Parser) 10.7±0.02µs 10.8±0.02µs +0.93%
String concatenation (Compiler) 1613.6±4.32ns 1588.1±2.54ns -1.58%
String concatenation (Execution) 5.3±0.01µs 5.3±0.02µs 0.00%
String concatenation (Parser) 7.3±0.02µs 7.4±0.04µs +1.37%
String copy (Compiler) 1271.5±1.95ns 1256.9±2.82ns -1.15%
String copy (Execution) 4.7±0.02µs 4.7±0.03µs 0.00%
String copy (Parser) 5.5±0.02µs 5.5±0.02µs 0.00%
Symbols (Compiler) 910.4±1.35ns 900.6±1.26ns -1.08%
Symbols (Execution) 4.6±0.01µs 4.6±0.01µs 0.00%
Symbols (Parser) 4.2±0.03µs 4.1±0.01µs -2.38%

@Razican
Copy link
Member

Razican commented Feb 28, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 28, 2022
It changes the following:
- Fix `Object.getOwnPropertyDescriptors()` to comply to spec
@bors
Copy link

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make Object.getOwnPropertyDescriptors spec compliant [Merged by Bors] - Make Object.getOwnPropertyDescriptors spec compliant Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the fix/Object.getOwnPropertyDescriptors branch February 28, 2022 18:07
@Razican Razican added this to the v0.14.0 milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants