[Merged by Bors] - Migrate to NPM and cleanup Playground #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
raskad
and removed request for
Razican
jedel1043
added
webassembly
Razican
reviewed
Mar 17, 2022
|
i'm sure the Github/workflow files are using yarn too. Did you do a search for yarn references? Also you mentioned ESBuild couldn't be used because of top-level await, where was top level await being used? |
Forgot about that 😅, I'll fix it ASAP.
If it was in our code it would be easier to fix, but it's used by https://github.com/Tschrock/esbuild-plugin-wasm. I also tried to export the wasm build as |
|
I’d been keen to take a look at this when I get some time, I’ve used the esbuild wasm plugin and not had issues before. |
That's related to https://github.com/Tschrock/esbuild-plugin-wasm-pack. The cause is rustwasm/wasm-pack#642, since the plugin tries to run |
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage 45.87% 45.87%
=======================================
Files 206 206
Lines 17102 17102
=======================================
Hits 7846 7846
Misses 9256 9256 Continue to review full report at Codecov.
|
|
https://github.com/boa-dev/boa/blob/main/.github/workflows/release.yml#L29-L39 will need changing to the npm equivalent |
Fixed! I also decided to use node 14 since its |
Benchmark for 2fd4956Click to view benchmark
|
Benchmark for 6879882Click to view benchmark
|
Benchmark for c66cbd3Click to view benchmark
|
Razican
approved these changes
Mar 17, 2022
RageKnify
reviewed
Mar 18, 2022
|
LGTM, agree with changing to node 16 |
raskad
requested changes
Mar 18, 2022
|
Unrolled downgrade to v14, switched to |
Benchmark for 32ff1d7Click to view benchmark
|
Benchmark for 96fd628Click to view benchmark
|
raskad
approved these changes
Mar 19, 2022
Benchmark for 3ecdfbaClick to view benchmark
|
jasonwilliams
approved these changes
Mar 20, 2022
Razican
approved these changes
Mar 20, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
This Pull Request closes #1912 by migrating to a NPM based build, hopefully making it easier to contribute to the Playground. Also, reduces the number of features of the editor, since most of them were support for other languages or features that don't make sense in a playground environment. This considerably reduces the number of fetched files per page load and the total size of the playground.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This Pull Request closes #1912 by migrating to a NPM based build, hopefully making it easier to contribute to the Playground. Also, reduces the number of features of the editor, since most of them were support for other languages or features that don't make sense in a playground environment. This considerably reduces the number of fetched files per page load and the total size of the playground.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #1912 by migrating to a NPM based build, hopefully making it easier to contribute to the Playground.
Also, reduces the number of features of the editor, since most of them were support for other languages or features that don't make sense in a playground environment. This considerably reduces the number of fetched files per page load and the total size of the playground.