[Merged by Bors] - Fix panic in do while #1968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
=======================================
Coverage 45.87% 45.87%
=======================================
Files 206 206
Lines 17102 17102
=======================================
Hits 7846 7846
Misses 9256 9256
Continue to review full report at Codecov.
|
HalidOdat
requested review from
jedel1043,
Razican,
raskad,
HalidOdat,
jasonwilliams and
RageKnify
HalidOdat
added
bug
|
Hi! Thanks for the contribution!! It seems it's missing a |
VM implementation
|
HalidOdat
approved these changes
Mar 22, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
`Node::DoWhileLoop` ast node had a buggy bytecode generation where `self.patch_jump(exit)` was called after emitting `LoopEnd` opcode. This would patch the loop exit to the instruction following the do while code, which would panic in cases where do while was enclosed in a block statement. This Pull Request fixes #1929. It changes the following: - Patch jump before emitting `Opcode::LoopEnd` - Add test which has do while statement inside a block statement to demonstrate that the change fixes the panic.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
`Node::DoWhileLoop` ast node had a buggy bytecode generation where `self.patch_jump(exit)` was called after emitting `LoopEnd` opcode. This would patch the loop exit to the instruction following the do while code, which would panic in cases where do while was enclosed in a block statement. This Pull Request fixes #1929. It changes the following: - Patch jump before emitting `Opcode::LoopEnd` - Add test which has do while statement inside a block statement to demonstrate that the change fixes the panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node::DoWhileLoopast node had a buggy bytecode generation whereself.patch_jump(exit)was called after emittingLoopEndopcode. This would patch the loop exit to the instruction following the do while code, which would panic in cases where do while was enclosed in a block statement.This Pull Request fixes #1929.
It changes the following:
Opcode::LoopEnd