[Merged by Bors] - Retrieve feature-based results for Test262 runs #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1980 +/- ##
=======================================
Coverage 45.93% 45.93%
=======================================
Files 206 206
Lines 17138 17138
=======================================
Hits 7873 7873
Misses 9265 9265
Continue to review full report at Codecov.
|
Razican
requested review from
Razican,
HalidOdat,
jasonwilliams,
jedel1043,
RageKnify and
raskad
Razican
added
enhancement
Razican
reviewed
Mar 27, 2022
boa_tester/src/exec/mod.rs
Outdated
| @@ -67,6 +74,7 @@ impl TestSuite { | |||
| passed += suite.passed; | |||
| ignored += suite.ignored; | |||
| panic += suite.panic; | |||
| features.append(&mut suite.features.clone()) | |||
There was a problem hiding this comment.
This is giving a clippy warning, should be fixed with this:
Suggested change
| features.append(&mut suite.features.clone()) | |
| features.append(&mut suite.features.clone()); |
There was a problem hiding this comment.
boa_tester/src/results.rs
Outdated
| features: Vec<String>, | ||
| } | ||
|
|
||
| fn remove_duplicates(features_vec: &Vec<String>) -> Vec<String> { |
There was a problem hiding this comment.
This should solve the clippy error, but might need some changes in the code to convert the slice to a vector.
Suggested change
| fn remove_duplicates(features_vec: &Vec<String>) -> Vec<String> { | |
| fn remove_duplicates(features_vec: &[String]) -> Vec<String> { |
There was a problem hiding this comment.
Razican
approved these changes
Mar 28, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
This Pull Request fixes/closes #1645. It changes the following: - Add `features` field to `SuiteResult` structure - Fetch features from `TestSuite` and propagate them via `SuiteResult` - Add `FeaturesInfo` structure and serialize it to `features.json`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This Pull Request fixes/closes #1645. It changes the following: - Add `features` field to `SuiteResult` structure - Fetch features from `TestSuite` and propagate them via `SuiteResult` - Add `FeaturesInfo` structure and serialize it to `features.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1645.
It changes the following:
featuresfield toSuiteResultstructureTestSuiteand propagate them viaSuiteResultFeaturesInfostructure and serialize it tofeatures.json