[Merged by Bors] - Partial implementation for Intl.DateTimeFormat #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertGarfield
force-pushed
the
garfield/date-time-format
branch
from
afad01b
to
a68edde
Compare
Codecov Report
@@ Coverage Diff @@
## main #2025 +/- ##
==========================================
- Coverage 43.94% 43.90% -0.04%
==========================================
Files 211 212 +1
Lines 18704 18734 +30
==========================================
+ Hits 8220 8226 +6
- Misses 10484 10508 +24
Continue to review full report at Codecov.
|
HalidOdat
reviewed
Apr 13, 2022
HalidOdat
reviewed
Apr 13, 2022
VM implementation
Fixed tests (50):Broken tests (6): |
|
@HalidOdat it seems to me that 6 failing tests were previously passing because In order to fix that I need to either implement Thanks. |
|
Sorry for late response
You can leave it as is, just put a |
NorbertGarfield
force-pushed
the
garfield/date-time-format
branch
from
181dd42
to
eddb5d4
Compare
Razican
approved these changes
Apr 18, 2022
Razican
requested review from
jedel1043,
raskad,
jasonwilliams,
RageKnify and
HalidOdat
and removed request for
HalidOdat
HalidOdat
approved these changes
Apr 19, 2022
HalidOdat
changed the title
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request provides initial implementation for DateTimeFormat constructor. It relates to #1562. It changes the following: - Adds `Intl.DateTimeFormat` property - Partially implements `DateTimeFormat` constructor (`InitializeDateTimeFormat` step is postponed). - Introduces `ObjectData::DateTimeFormat`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
added a commit
that referenced
this pull request
Jun 8, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request provides initial implementation for DateTimeFormat constructor. It relates to #1562. It changes the following: - Adds `Intl.DateTimeFormat` property - Partially implements `DateTimeFormat` constructor (`InitializeDateTimeFormat` step is postponed). - Introduces `ObjectData::DateTimeFormat`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request provides initial implementation for DateTimeFormat constructor. It relates to #1562.
It changes the following:
Intl.DateTimeFormatpropertyDateTimeFormatconstructor (InitializeDateTimeFormatstep is postponed).ObjectData::DateTimeFormat