Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Allow creating object with true/false property names #2028

Closed
wants to merge 1 commit into from

Conversation

lupd
Copy link
Contributor

@lupd lupd commented Apr 14, 2022

This Pull Request allows "true"/"false" as property names when instantiating objects. This should make some additional tests in the test suite pass.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #2028 (02fa6d8) into main (34303f1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   44.15%   44.14%   -0.01%     
==========================================
  Files         210      210              
  Lines       18596    18599       +3     
==========================================
  Hits         8211     8211              
- Misses      10385    10388       +3     
Impacted Files Coverage Δ
...arser/expression/primary/object_initializer/mod.rs 38.39% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34303f1...02fa6d8. Read the comment docs.

@raskad
Copy link
Member

raskad commented Apr 14, 2022

VM implementation

Test result main count PR count difference
Total 88,720 88,720 0
Passed 53,146 53,152 +6
Ignored 21,853 21,853 0
Failed 13,721 13,715 -6
Panics 0 0 0
Conformance 59.90% 59.91% +0.01%
Fixed tests (6):
test/language/expressions/object/S11.1.5_A4.1.js [strict mode] (previously Failed)
test/language/expressions/object/S11.1.5_A4.1.js (previously Failed)
test/language/reserved-words/ident-name-reserved-word-literal-prop-name.js [strict mode] (previously Failed)
test/language/reserved-words/ident-name-reserved-word-literal-prop-name.js (previously Failed)
test/language/reserved-words/ident-name-reserved-word-literal-accessor.js [strict mode] (previously Failed)
test/language/reserved-words/ident-name-reserved-word-literal-accessor.js (previously Failed)

@raskad raskad added this to the v0.15.0 milestone Apr 14, 2022
@raskad raskad added enhancement New feature or request parser Issues surrounding the parser labels Apr 14, 2022
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find :)

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 14, 2022
This Pull Request allows "true"/"false" as property names when instantiating objects. This should make some additional tests in the test suite pass.
@bors
Copy link

bors bot commented Apr 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow creating object with true/false property names [Merged by Bors] - Allow creating object with true/false property names Apr 14, 2022
@bors bors bot closed this Apr 14, 2022
Razican pushed a commit that referenced this pull request Jun 8, 2022
This Pull Request allows "true"/"false" as property names when instantiating objects. This should make some additional tests in the test suite pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants