[Merged by Bors] - Fixing build for changes in clippy for Rust 1.61 #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
|
Probably the same as #2079? |
Yep, but I would prefer having both separated. I just fixed it since it was throwing errors, I can rebase over this PR |
Test262 conformance changesVM implementation
|
jedel1043
approved these changes
May 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #2082 +/- ##
==========================================
+ Coverage 44.10% 44.17% +0.07%
==========================================
Files 215 215
Lines 19368 19371 +3
==========================================
+ Hits 8542 8558 +16
+ Misses 10826 10813 -13
Continue to review full report at Codecov.
|
raskad
approved these changes
May 20, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 20, 2022
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the `use_self` lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902. It removed some false negatives, though, so I fixed some of the usage.
Benchmark for ec07449Click to view benchmark
|
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
added a commit
that referenced
this pull request
Jun 8, 2022
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the `use_self` lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902. It removed some false negatives, though, so I fixed some of the usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the
use_selflint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902.It removed some false negatives, though, so I fixed some of the usage.