[Merged by Bors] - Implement super expressions
#2116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
enhancement
Test262 conformance changesVM implementation
Fixed tests (496): |
raskad
requested review from
Razican,
jedel1043,
HalidOdat,
jasonwilliams and
RageKnify
Codecov Report
@@ Coverage Diff @@
## main #2116 +/- ##
==========================================
- Coverage 43.52% 42.68% -0.84%
==========================================
Files 220 222 +2
Lines 20028 20763 +735
==========================================
+ Hits 8717 8863 +146
- Misses 11311 11900 +589
Continue to review full report at Codecov.
|
Benchmark for f4aa3ecClick to view benchmark
|
Razican
reviewed
Jun 13, 2022
| /// Parse the given source text in strict mode. | ||
| pub(crate) fn parse_strict<S>(&mut self, src: S) -> Result<StatementList, ParseError> | ||
| /// Parse the given source text with eval specific handling. | ||
| pub(crate) fn parse_eval<S>( |
There was a problem hiding this comment.
We can probably use this in boa_tester, in the $262 object that gets passed to the context. It has a special eval function that currently does the parsing twice, but can probably benefit from this.
There was a problem hiding this comment.
You mean $262.evalScript() right? I think that is different. This one is specific to the PerformEval op: https://tc39.es/ecma262/#sec-performeval
There was a problem hiding this comment.
Ye, that's what I meant xD didn't remember it well. But yes, I get that. Maybe we can do the same somehow in evalScript().
Benchmark for bc073cbClick to view benchmark
|
bors bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
This changes the trigger type for PR benchmarks back to the default (`opened`, `synchronize`, `reopened`). As part of #2114 I added the `labeled` trigger type. This causes the benchmarks to run when the `run-benchmark` label is present and another label is added. For example in #2116 I added the `run-benchmark` label while creating the PR. The benchmarks then where triggered six times; one for the PR creation (`opened`) and five times for each label that I initially added to the PR. The only drawback is that the benchmarks are not triggered, when we just add the label, but unfortunately I don't have a clever idea on how to achieve that right now. We will have to add the label and then trigger the run via a `synchronize` (push).
Razican
reviewed
Jun 13, 2022
| Ok(body) => body, | ||
| Err(e) => return context.throw_syntax_error(e), | ||
| Err(e) => return context.throw_syntax_error(e.to_string()), |
There was a problem hiding this comment.
That works too, yes, but my thoughts were more on using the following:
map_err(ToString::to_string)instead of adding a closure in map_err, but maybe it wasn't possible, due to by value/by reference function signatures.
|
Rebased. |
Benchmark for c10876aClick to view benchmark
|
Razican
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
I've reviewed it, but I'm not confident enough with the VM. Looks pretty good, but I expect a hit in Parser performance, due to the tree traversal.
I added some comments, mostly related to documentation, but now that I think of it, adding backticks everywhere might not make much sense xD just give it a look and let me know :)
boa_engine/src/syntax/parser/expression/primary/object_initializer/mod.rs
Show resolved
Hide resolved
boa_engine/src/syntax/parser/expression/primary/object_initializer/mod.rs
Show resolved
Hide resolved
HalidOdat
approved these changes
Jun 29, 2022
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Benchmark for 0353c96Click to view benchmark
|
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
super expressionssuper expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
superexpression parsing / execution.superexpressions.