String.prototype.replace() #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 9502716Click to view benchmark
|
Benchmark for 1f35b0aClick to view benchmark
|
Benchmark for ac706b4Click to view benchmark
|
Benchmark for dd1a5baClick to view benchmark
|
jasonwilliams
force-pushed
the
string-replace-2
branch
from
1b1e6b0
to
d012b61
Compare
src/lib/builtins/string.rs
Outdated
| @@ -322,6 +324,117 @@ pub fn includes(this: &Value, args: &[Value], ctx: &mut Interpreter) -> ResultVa | |||
| Ok(to_value(this_string.contains(&search_string))) | |||
| } | |||
|
|
|||
| /// Return either the string itself or the string of the regex equivalent | |||
| fn get_regex_string(value: &Value) -> String { | |||
| let mut regex_body = String::new(); | |||
There was a problem hiding this comment.
You don't need this, you can return directly from the match
Benchmark for 73cf613Click to view benchmark
|
jasonwilliams
force-pushed
the
string-replace-2
branch
from
d012b61
to
4fd9767
Compare
Benchmark for 9ab3495Click to view benchmark
|
Benchmark for b042f00Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.