feat: Implement Array.prototype.toString #218
Conversation
src/lib/builtins/array.rs
Outdated
| ValueData::String(ref s) => (*s).clone(), | ||
| _ => "".to_string(), | ||
| }, | ||
| Err(v) => format!("{}: {}", "error", v.to_string()), |
There was a problem hiding this comment.
No need for "error" to be a separate param, you can change the template to "error: {}".
Also, no need for .to_string(), v will be formatted accordingly to its value anyway.
There was a problem hiding this comment.
nice advice
No need for
"error"to be a separate param, you can change the template to"error: {}".Also, no need for
.to_string(),vwill be formatted accordingly to its value anyway.
nice advice，thank you!
|
Looks good, sync you branch with master so the pipeline runs, and we are all set |
There was a problem hiding this comment.
Looks good, sync you branch with master so the pipeline runs, and we are all set
Array.prototype.toString should be passed the tests like jerryscript's。But without enough continuous time，I had to implement a simplified one first。Next，I will improve it.
src/lib/builtins/array.rs
Outdated
| ValueData::String(ref s) => (*s).clone(), | ||
| _ => "".to_string(), | ||
| }, | ||
| Err(v) => format!("{}: {}", "error", v.to_string()), |
There was a problem hiding this comment.
nice advice
No need for
"error"to be a separate param, you can change the template to"error: {}".Also, no need for
.to_string(),vwill be formatted accordingly to its value anyway.
nice advice，thank you!
I am a rust newbie and my code may not be good. But I will continue to improve this code.