[Merged by Bors] - Add integer type to fast path of to_property_key #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunz
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
+ Coverage 41.31% 41.34% +0.02%
==========================================
Files 234 234
Lines 22019 22023 +4
==========================================
+ Hits 9097 9105 +8
+ Misses 12922 12918 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
requested review from
raskad,
Razican,
HalidOdat,
RageKnify and
jasonwilliams
jedel1043
added
execution
|
Very nice optimization. I think we could event optimize this further if I read the spec right. The slow path using |
|
Updated. There was no notable performance improvement though since |
Razican
added
run-benchmark
Benchmarks |
Razican
approved these changes
Sep 5, 2022
|
Thanks for review :) |
Interesting indeed, as I have the same hardware. But might have been that I had other stuff running at the same time. No worries, the optimization seems very reasonable :) |
jedel1043
approved these changes
Sep 5, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2022
Skip `to_string` for integer type primitives in `to_property_key`. It's unnecessary to convert the integer value to string and convert back to `Index(u32)` type.
In this example code, it improves around 10% of runtime.
```js
let arr = [1,2,3,4,5];
for (let i = 0; i < 10000000; i++) {
arr[0] = 123;
}
```
Before: 6.24s
After: 5.38s
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
to_stringfor integer type primitives into_property_key. It's unnecessary to convert the integer value to string and convert back toIndex(u32)type.In this example code, it improves around 10% of runtime.
Before: 6.24s
After: 5.38s