Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix property access of call expression #2273

Closed
wants to merge 4 commits into from

Conversation

tunz
Copy link
Contributor

@tunz tunz commented Sep 9, 2022

Fix a syntax error when accessing literal-like property names of call expression.
e.g.) fn().true

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2273 (1e88b45) into main (b63d04c) will increase coverage by 0.02%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             main    #2273      +/-   ##
==========================================
+ Coverage   41.33%   41.35%   +0.02%     
==========================================
  Files         234      234              
  Lines       22019    22019              
==========================================
+ Hits         9101     9107       +6     
+ Misses      12918    12912       -6     
Impacted Files Coverage Δ
...src/syntax/parser/expression/left_hand_side/mod.rs 45.45% <ø> (ø)
boa_interner/src/sym.rs 0.00% <ø> (ø)
...rc/syntax/parser/expression/left_hand_side/call.rs 36.66% <33.33%> (+1.37%) ⬆️
.../syntax/parser/expression/left_hand_side/member.rs 31.95% <37.50%> (+5.03%) ⬆️
...oa_engine/src/syntax/parser/statement/block/mod.rs 41.46% <0.00%> (-2.44%) ⬇️
boa_engine/src/builtins/function/mod.rs 23.71% <0.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Razican
Copy link
Member

Razican commented Sep 9, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 91,733 91,733 0
Passed 64,890 64,894 +4
Ignored 16,580 16,580 0
Failed 10,263 10,259 -4
Panics 0 0 0
Conformance 70.74% 70.74% +0.00%
Fixed tests (4):
test/language/statements/class/elements/private-methods/prod-private-method-initialize-order.js [strict mode] (previously Failed)
test/language/statements/class/elements/private-methods/prod-private-method-initialize-order.js (previously Failed)
test/language/expressions/class/elements/private-methods/prod-private-method-initialize-order.js [strict mode] (previously Failed)
test/language/expressions/class/elements/private-methods/prod-private-method-initialize-order.js (previously Failed)

@Razican Razican added the bug Something isn't working label Sep 9, 2022
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix :) Just a suggestion to reduce code repetition and make things more readable.

@Razican Razican added the parser Issues surrounding the parser label Sep 9, 2022
@Razican Razican added this to the v0.16.0 milestone Sep 9, 2022
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for the additional tests and match fixes.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Thanks! LGTM

@Razican
Copy link
Member

Razican commented Sep 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Sep 10, 2022
Fix a syntax error when accessing literal-like property names of call expression.
e.g.) `fn().true`
@bors
Copy link

bors bot commented Sep 10, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix property access of call expression [Merged by Bors] - Fix property access of call expression Sep 10, 2022
@bors bors bot closed this Sep 10, 2022
@tunz tunz deleted the tunz/call-expr-prop branch September 12, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants