Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement missing global object internal methods #2287

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Implement missing global object internal methods #2287

wants to merge 2 commits into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 18, 2022

This Pull Request fixes/closes #1987.

It changes the following:

  • Add a prototype to the global object.
  • Implement __get_prototype_of__, __set_prototype_of__, __get_own_property__, and __own_property_keys__ for the global object

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Sep 18, 2022
@raskad raskad added this to the v0.17.0 milestone Sep 18, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 91,827 91,827 0
Passed 66,244 66,319 +75
Ignored 16,672 16,672 0
Failed 8,911 8,836 -75
Panics 0 0 0
Conformance 72.14% 72.22% +0.08%
Fixed tests (75): 
test/built-ins/decodeURI/S15.1.3.1_A5.5.js [strict mode] (previously Failed)
test/built-ins/decodeURI/S15.1.3.1_A5.5.js (previously Failed)
test/built-ins/decodeURIComponent/S15.1.3.2_A5.5.js [strict mode] (previously Failed)
test/built-ins/decodeURIComponent/S15.1.3.2_A5.5.js (previously Failed)
test/built-ins/parseInt/S15.1.2.2_A9.5.js [strict mode] (previously Failed)
test/built-ins/parseInt/S15.1.2.2_A9.5.js (previously Failed)
test/built-ins/parseFloat/S15.1.2.3_A7.5.js [strict mode] (previously Failed)
test/built-ins/parseFloat/S15.1.2.3_A7.5.js (previously Failed)
test/built-ins/Object/defineProperties/15.2.3.7-2-18.js [strict mode] (previously Failed)
test/built-ins/Object/defineProperties/15.2.3.7-2-18.js (previously Failed)
test/built-ins/Object/defineProperties/15.2.3.7-6-a-24.js [strict mode] (previously Failed)
test/built-ins/Object/defineProperties/15.2.3.7-6-a-24.js (previously Failed)
test/built-ins/Object/defineProperty/15.2.3.6-4-625gs.js [strict mode] (previously Failed)
test/built-ins/Object/defineProperty/15.2.3.6-4-625gs.js (previously Failed)
test/built-ins/Object/getOwnPropertyNames/15.2.3.4-4-1.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyNames/15.2.3.4-4-1.js (previously Failed)
test/built-ins/Object/getPrototypeOf/15.2.3.2-2-30.js [strict mode] (previously Failed)
test/built-ins/Object/getPrototypeOf/15.2.3.2-2-30.js (previously Failed)
test/built-ins/encodeURI/S15.1.3.3_A5.5.js [strict mode] (previously Failed)
test/built-ins/encodeURI/S15.1.3.3_A5.5.js (previously Failed)
test/built-ins/encodeURIComponent/S15.1.3.4_A5.5.js [strict mode] (previously Failed)
test/built-ins/encodeURIComponent/S15.1.3.4_A5.5.js (previously Failed)
test/language/eval-code/indirect/var-env-func-init-global-update-non-configurable.js [strict mode] (previously Failed)
test/language/eval-code/indirect/var-env-func-init-global-update-non-configurable.js (previously Failed)
test/language/eval-code/indirect/var-env-func-init-global-new.js [strict mode] (previously Failed)
test/language/eval-code/indirect/var-env-func-init-global-new.js (previously Failed)
test/language/eval-code/indirect/var-env-var-init-global-new.js [strict mode] (previously Failed)
test/language/eval-code/indirect/var-env-var-init-global-new.js (previously Failed)
test/language/eval-code/direct/var-env-func-init-global-update-non-configurable.js (previously Failed)
test/language/eval-code/direct/var-env-func-init-global-new.js (previously Failed)
test/language/eval-code/direct/var-env-var-init-global-new.js (previously Failed)
test/language/statements/variable/S12.2_A9.js [strict mode] (previously Failed)
test/language/statements/variable/S12.2_A9.js (previously Failed)
test/language/global-code/decl-lex.js [strict mode] (previously Failed)
test/language/global-code/decl-lex.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/switch-case-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-existing-global-init.js (previously Failed)
test/annexB/language/global-code/block-decl-global-existing-global-init.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #2287 (cbf527f) into main (779384d) will decrease coverage by 0.08%.
The diff coverage is 5.66%.

@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
- Coverage   41.40%   41.31%   -0.09%     
==========================================
  Files         237      237              
  Lines       22218    22266      +48     
==========================================
+ Hits         9199     9200       +1     
- Misses      13019    13066      +47
Impacted Files Coverage Δ
boa_engine/src/object/internal_methods/global.rs 24.37% <0.00%> (-10.45%) ⬇️
boa_engine/src/context/mod.rs 31.16% <100.00%> (+0.43%) ⬆️
boa_engine/src/realm.rs 53.84% <100.00%> (ø)
boa_engine/src/builtins/set/ordered_set.rs 7.40% <0.00%> (-7.41%) ⬇️
boa_engine/src/vm/mod.rs 46.90% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Razican
Razican approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@Razican Razican modified the milestones: v0.17.0, v0.16.0 Sep 19, 2022
@Razican
Copy link
Member

Razican commented Sep 19, 2022

bors r+

bors bot pushed a commit that referenced this pull request Sep 19, 2022
@raskad
Implement missing global object internal methods (#2287)
db8a299 
This Pull Request fixes/closes #1987.

It changes the following:

- Add a prototype to the global object.
- Implement `__get_prototype_of__`, `__set_prototype_of__`, `__get_own_property__`, and `__own_property_keys__` for the global object
@bors
Copy link

bors bot commented Sep 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement missing global object internal methods [Merged by Bors] - Implement missing global object internal methods Sep 19, 2022
@bors bors bot closed this Sep 19, 2022
@bors bors bot deleted the global-object-missing-internal-methods branch September 19, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError when calling method on global object
3 participants
@raskad @Razican @jedel1043