Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy, revert to just correctness, perf and style #232

Merged
merged 1 commit into from
Jan 21, 2020
Merged

fix clippy, revert to just correctness, perf and style #232

merged 1 commit into from
Jan 21, 2020

Conversation

jasonwilliams
Copy link
Member

This removes all of the clippy warnings

@github-actions
Copy link

Benchmark for 0627a2c

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 472.3±111.80µs 454.7±21.51µs 104%
Expression (Parser) 10.5±0.50µs 10.5±0.53µs 100%
Hello World (Execution) 481.5±18.32µs 480.9±46.97µs 100%
Hello World (Lexer) 1066.1±74.93ns 1027.8±67.83ns 104%
Hello World (Parser) 1142.3±53.09ns 1150.9±133.95ns 99%
Symbol Creation 559.7±35.99µs 551.2±32.44µs 102%
fibonacci (Execution) 5.5±0.16ms 5.5±0.27ms 101%
undefined undefined 100%

@jasonwilliams jasonwilliams merged commit fe4a889 into master Jan 21, 2020
@jasonwilliams jasonwilliams deleted the fix_clippy branch April 3, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jasonwilliams